You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/29 22:54:06 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
v01d opened a new pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164
## Summary
Add configuration which uses the X11 framebuffer window to draw LVGL demo app and emulated touchscreen
with mouse.
## Impact
New configuration
## Testing
This requires the changes in https://github.com/apache/incubator-nuttx-apps/pull/451 since if LVGL internal memory handling is used, it segfaults
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719132061
Yeah if you click rerun it will pick up the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719122199
I was going to mention this. You should either add it to one of the existing X11 targets (likey does not make sense) or just add the exception to sim.dat in testing and then kick the build again. @xiaoxiang781216 and I just got the infra in for doing that. I'll happily merge it.
The one thing I would say is when possible let's keep the configs combined since they add up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719197153
@v01d I just merged the app side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719109557
Mmm, this is failing since it tries to access X11 headers on macOS. How should this be handled? Should CI skip this platform for this config somehow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719123149
> I was going to mention this. You should either add it to one of the existing X11 targets (likey does not make sense) or just add the exception to sim.dat in testing and then kick the build again. @xiaoxiang781216 and I just got the infra in for doing that. I'll happily merge it.
I think it is better to add the exception.
> The one thing I would say is when possible let's keep the configs combined since they add up.
I agree. In this case I think it is worth it since there's quite a bit of configs required to make this work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719301656
hmm I got this one time, but I was not able to reproduce it. I suspect it might actually have been a lvgl bug that I hit. Seems unrelated and the rest of the demo worked great! Thanks for adding it.
```
❯ ./nuttx
VideoInfo:
fmt: 13
xres: 640
yres: 480
nplanes: 1
PlaneInfo (plane 0):
fbmem: 0x7f004a4dc000
fblen: 1228800
stride: 2560
display: 0
bpp: 32
Mapped FB: 0x7f004a4dc000
tp_init: Opening /dev/input0
tp_cal result
offset x:13, y:10
range x:0, y:5
invert x/y:1, x:0, y:0
Floating point exception (core dumped)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719123564
Cool just tag me and I'll merge it prior to CI since there is nothing it will catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2164: sim: add LVGL configuration which uses the X11 framebuffer and mouse
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2164:
URL: https://github.com/apache/incubator-nuttx/pull/2164#issuecomment-719130690
Should I re-run CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org