You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/27 17:19:52 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1173: testing/ostest: Replace up_tls_info with tls_get_info
xiaoxiang781216 opened a new pull request, #1173:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1173
## Summary
follow the kernel side change
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1173: testing/ostest: Replace up_tls_info with tls_get_info
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1173:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1173#issuecomment-1140289355
> Could you please share the upcoming kernel side changes? Now we have
>
> ```
> #ifndef up_tls_info
> # if defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__)
> # define up_tls_info() TLS_INFO((uintptr_t)up_getsp())
> # else
> # define up_tls_info() tls_get_info()
> # endif
> #endif
> ```
>
> so this change covers only the `else` case of `if defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__)`.
Here is patch:
https://github.com/apache/incubator-nuttx/pull/6337/commits/c9b5292676feea98bbb1901d14236d1a0dc7e3a2
This patch need merge first otherwise the above PR can't pass CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1173: testing/ostest: Replace up_tls_info with tls_get_info
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1173:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1173#discussion_r883870858
##########
testing/ostest/tls.c:
##########
@@ -48,17 +47,17 @@ static struct tls_info_s g_save_info;
static void get_tls_info(FAR struct tls_info_s *info)
{
- memcpy(info, up_tls_info(), sizeof(struct tls_info_s));
+ memcpy(info, tls_get_info(), sizeof(struct tls_info_s));
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1173: testing/ostest: Replace up_tls_info with tls_get_info
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1173:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1173: testing/ostest: Replace up_tls_info with tls_get_info
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1173:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1173#issuecomment-1140285492
Could you please share the upcoming kernel side changes?
Now we have
```
#ifndef up_tls_info
# if defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__)
# define up_tls_info() TLS_INFO((uintptr_t)up_getsp())
# else
# define up_tls_info() tls_get_info()
# endif
#endif
```
so this change covers only the `else` case of `if defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1173: testing/ostest: Replace up_tls_info with tls_get_info
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1173:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1173#discussion_r883858510
##########
testing/ostest/tls.c:
##########
@@ -48,17 +47,17 @@ static struct tls_info_s g_save_info;
static void get_tls_info(FAR struct tls_info_s *info)
{
- memcpy(info, up_tls_info(), sizeof(struct tls_info_s));
+ memcpy(info, tls_get_info(), sizeof(struct tls_info_s));
Review Comment:
Anyway minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1173: testing/ostest: Replace up_tls_info with tls_get_info
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1173:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1173#discussion_r883806684
##########
testing/ostest/tls.c:
##########
@@ -48,17 +47,17 @@ static struct tls_info_s g_save_info;
static void get_tls_info(FAR struct tls_info_s *info)
{
- memcpy(info, up_tls_info(), sizeof(struct tls_info_s));
+ memcpy(info, tls_get_info(), sizeof(struct tls_info_s));
Review Comment:
Maybe we can switch to define instead? Seems like a simple wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org