You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/24 01:34:07 UTC
[GitHub] eric-haibin-lin commented on a change in pull request #9534: Text APIs: interface name change
eric-haibin-lin commented on a change in pull request #9534: Text APIs: interface name change
URL: https://github.com/apache/incubator-mxnet/pull/9534#discussion_r163432732
##########
File path: docs/api/python/text/text.md
##########
@@ -121,13 +121,13 @@ by specifying their indices (2 and 1) and the `glossary.idx_to_vec` in
```
-## Glossary
+## CompositeEmbedding
The glossary provides indexing and embedding for text tokens in a glossary. For
each indexed token in a glossary, an embedding vector will be associated with
it. Such embedding vectors can be loaded from externally hosted or custom
pre-trained token embedding files, such as via instances of
-[`TokenEmbedding`](#mxnet.contrib.text.embedding.TokenEmbedding).
+[`_TokenEmbedding`](#mxnet.contrib.text.embedding.TokenEmbedding).
Review comment:
Do you also need to update the reference `mxnet.contrib.text.embedding.TokenEmbedding `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services