You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by klopfdreh <gi...@git.apache.org> on 2015/12/23 09:01:02 UTC

[GitHub] wicket pull request: Fixed calculation of byte ranges

GitHub user klopfdreh opened a pull request:

    https://github.com/apache/wicket/pull/149

    Fixed calculation of byte ranges

    To test the correct behavior use curl:
    
    curl --range 0-99 &lt;pathToMovie.mp4&gt; -o /dev/null
    
    as of the developer page of Apple this should return 100 bytes, now:
    
    https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klopfdreh/wicket byte_ranges_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #149
    
----
commit f96c37df975196f79020ee4debdb8d7eb3bbbd96
Author: Tobias Soloschenko <ts...@sapient.com>
Date:   2015-12-23T07:56:07Z

    Fixed calculation of byte ranges

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Fixed calculation of byte ranges

Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh closed the pull request at:

    https://github.com/apache/wicket/pull/149


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Fixed calculation of byte ranges

Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the pull request:

    https://github.com/apache/wicket/pull/149#issuecomment-167364241
  
    Fixed: https://github.com/apache/wicket/commit/a169eb1125d93867c64377a8dc4066491ef510c7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---