You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/02/02 01:55:10 UTC
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12339
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
The new commit in Impala-lzo/master breaks the builds of Impala-2.x.
We should depend on a dedicated branch for 2.x.
Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/12339/1
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12339
to look at the new patch set (#2).
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
The new commit in Impala-lzo/master breaks the builds of Impala-2.x.
We should depend on a dedicated branch for 2.x.
Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
---
M bin/bootstrap_system.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/12339/2
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1969/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Feb 2019 02:44:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12339/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/12339/1/bin/bootstrap_system.sh@209
PS1, Line 209: git clone https://github.com/cloudera/impala-lzo.git --branch 2.x --single-branch "$IMPALA_LZO_HOME"
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Feb 2019 01:55:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12339
to look at the new patch set (#4).
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
The new commit in Impala-lzo/master breaks the builds of Impala-2.x.
We should depend on a dedicated branch for 2.x.
Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/12339/4
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
The new commit in Impala-lzo/master breaks the builds of Impala-2.x.
We should depend on a dedicated branch for 2.x.
Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Reviewed-on: http://gerrit.cloudera.org:8080/12339
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Fredy Wijaya: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1968/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Feb 2019 02:35:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3753/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 05:28:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Feb 2019 06:44:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has restored this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Restored
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: restore
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2068/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 05:05:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 16:56:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3699/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Feb 2019 02:47:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3755/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 07:38:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3753/
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 06:23:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has abandoned this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Abandoned
Don't need this since the default branch of impala-lzo is cdh5-trunk which currently identical to 2.x.
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: abandon
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-8155: Modify bootstrap system.sh to bind Impala-lzo/2.x
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12339 )
Change subject: IMPALA-8155: Modify bootstrap_system.sh to bind Impala-lzo/2.x
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67591c7cfc4bede5c096a49beb57da34bb697338
Gerrit-Change-Number: 12339
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 11:32:22 +0000
Gerrit-HasComments: No