You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/25 20:06:10 UTC
[GitHub] [fineract] Grandolf49 opened a new pull request #1203: Swagger Codegen Integration
Grandolf49 opened a new pull request #1203:
URL: https://github.com/apache/fineract/pull/1203
## Description
Integrated support for building API Client from OpenAPI Specification file. [FINERACT-838](https://issues.apache.org/jira/browse/FINERACT-838)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [x] Integration tests have been created/updated for verifying the changes made.
- [x] All Integrations tests are passing with the new commits.
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 closed pull request #1203: FINERACT-838 Swagger Codegen Integration
Posted by GitBox <gi...@apache.org>.
Grandolf49 closed pull request #1203:
URL: https://github.com/apache/fineract/pull/1203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 commented on pull request #1203: FINERACT-838 Swagger Codegen Integration
Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on pull request #1203:
URL: https://github.com/apache/fineract/pull/1203#issuecomment-664033098
Closing this PR since it contains inconsistent commit messages and the build is failing too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 commented on a change in pull request #1203: FINERACT-838 Swagger Codegen Integration
Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on a change in pull request #1203:
URL: https://github.com/apache/fineract/pull/1203#discussion_r460567259
##########
File path: fineract-provider/build.gradle
##########
@@ -55,7 +55,8 @@ buildscript {
classpath "gradle.plugin.com.gorylenko.gradle-git-properties:gradle-git-properties:2.2.2"
classpath "net.ltgt.gradle:gradle-errorprone-plugin:1.2.1"
classpath "com.diffplug.spotless:spotless-plugin-gradle:5.1.0"
- classpath "io.swagger.core.v3:swagger-gradle-plugin:2.1.4"
+ classpath "io.swagger.core.v3:swagger-gradle-plugin:2.1.3"
Review comment:
Hi @thesmallstar Yes, you're right, this change was not necessary. I have created a new PR for this. Please review #1206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1203: FINERACT-838 Swagger Codegen Integration
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1203:
URL: https://github.com/apache/fineract/pull/1203#issuecomment-663984042
You need to do `./gradlew spotlessApply` for the build to pass :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on a change in pull request #1203: FINERACT-838 Swagger Codegen Integration
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on a change in pull request #1203:
URL: https://github.com/apache/fineract/pull/1203#discussion_r460523695
##########
File path: fineract-provider/build.gradle
##########
@@ -55,7 +55,8 @@ buildscript {
classpath "gradle.plugin.com.gorylenko.gradle-git-properties:gradle-git-properties:2.2.2"
classpath "net.ltgt.gradle:gradle-errorprone-plugin:1.2.1"
classpath "com.diffplug.spotless:spotless-plugin-gradle:5.1.0"
- classpath "io.swagger.core.v3:swagger-gradle-plugin:2.1.4"
+ classpath "io.swagger.core.v3:swagger-gradle-plugin:2.1.3"
Review comment:
Are you sure about this change? Does the newer version bring some issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org