You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/10 18:20:09 UTC

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5712: boards/Kconfig: introduce ARCH_BOARD_COMMON option

pkarashchenko opened a new pull request #5712:
URL: https://github.com/apache/incubator-nuttx/pull/5712


   ## Summary
   Introduce `ARCH_BOARD_COMMON` option
   
   ## Impact
   Custom boards users.
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5712: boards/Kconfig: introduce ARCH_BOARD_COMMON option

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5712:
URL: https://github.com/apache/incubator-nuttx/pull/5712


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5712: boards/Kconfig: introduce ARCH_BOARD_COMMON option

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5712:
URL: https://github.com/apache/incubator-nuttx/pull/5712#discussion_r824039849



##########
File path: boards/xtensa/esp32s3/common/Makefile
##########
@@ -31,3 +33,5 @@ include $(TOPDIR)/boards/Board.mk
 ARCHSRCDIR = $(TOPDIR)$(DELIM)arch$(DELIM)$(CONFIG_ARCH)$(DELIM)src
 BOARDDIR = $(ARCHSRCDIR)$(DELIM)board
 CFLAGS += $(shell $(INCDIR) "$(CC)" $(BOARDDIR)$(DELIM)include)
+
+endif

Review comment:
       Missing newline at the end of file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org