You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/10 10:11:58 UTC
[GitHub] [spark] GuoPhilipse opened a new pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
GuoPhilipse opened a new pull request #28782:
URL: https://github.com/apache/spark/pull/28782
### What changes were proposed in this pull request?
remove duplicate test cases
### Why are the changes needed?
improve test quality
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
No test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642076960
**[Test build #123760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123760/testReport)** for PR 28782 at commit [`c4f9a62`](https://github.com/apache/spark/commit/c4f9a62c1a7e1d3a86f290d65370d6b8e1bf539d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641951164
**[Test build #123760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123760/testReport)** for PR 28782 at commit [`c4f9a62`](https://github.com/apache/spark/commit/c4f9a62c1a7e1d3a86f290d65370d6b8e1bf539d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641951687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642621864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642510698
**[Test build #123838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123838/testReport)** for PR 28782 at commit [`c7b81d2`](https://github.com/apache/spark/commit/c7b81d24f3f19de202bf82ab598efd41efd38bfa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642390533
**[Test build #123819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123819/testReport)** for PR 28782 at commit [`c7b81d2`](https://github.com/apache/spark/commit/c7b81d24f3f19de202bf82ab598efd41efd38bfa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642510698
**[Test build #123838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123838/testReport)** for PR 28782 at commit [`c7b81d2`](https://github.com/apache/spark/commit/c7b81d24f3f19de202bf82ab598efd41efd38bfa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641904533
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642455285
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123819/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642390533
**[Test build #123819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123819/testReport)** for PR 28782 at commit [`c7b81d2`](https://github.com/apache/spark/commit/c7b81d24f3f19de202bf82ab598efd41efd38bfa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641904533
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642455277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641948864
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642078033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642078033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642389024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642511800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642511800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642454633
**[Test build #123819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123819/testReport)** for PR 28782 at commit [`c7b81d2`](https://github.com/apache/spark/commit/c7b81d24f3f19de202bf82ab598efd41efd38bfa).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642633986
Merged to master, branch-3.0 and branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642508741
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28782:
URL: https://github.com/apache/spark/pull/28782#discussion_r438238068
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -580,9 +577,6 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
assert(-1200 == res.getInt(0))
}
- createQueryTest("timestamp cast #8",
- "SELECT CAST(CAST(-1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1")
-
Review comment:
Instead of removing them, maybe we can change them? As you see that these tests are with numbers (#4 and #8), removing them makes the numbers not continuous now. Not strongly option, anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642483440
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28782:
URL: https://github.com/apache/spark/pull/28782#discussion_r438478923
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -580,9 +577,6 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
assert(-1200 == res.getInt(0))
}
- createQueryTest("timestamp cast #8",
- "SELECT CAST(CAST(-1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1")
-
Review comment:
Yeah, we can rename them to make it prettier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28782:
URL: https://github.com/apache/spark/pull/28782#discussion_r438479535
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -580,9 +577,6 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
assert(-1200 == res.getInt(0))
}
- createQueryTest("timestamp cast #8",
- "SELECT CAST(CAST(-1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1")
-
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641951164
**[Test build #123760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123760/testReport)** for PR 28782 at commit [`c4f9a62`](https://github.com/apache/spark/commit/c4f9a62c1a7e1d3a86f290d65370d6b8e1bf539d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641951687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642389024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28782:
URL: https://github.com/apache/spark/pull/28782#discussion_r438060807
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -564,9 +564,6 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
assert(1200 == res.getInt(0))
}
- createQueryTest("timestamp cast #4",
- "SELECT CAST(CAST(1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1")
Review comment:
hm, as you suggested, the test looks duplicate. cc: @HyukjinKwon @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28782:
URL: https://github.com/apache/spark/pull/28782#discussion_r438236216
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -564,9 +564,6 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
assert(1200 == res.getInt(0))
}
- createQueryTest("timestamp cast #4",
- "SELECT CAST(CAST(1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1")
Review comment:
Looks duplicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642619244
**[Test build #123838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123838/testReport)** for PR 28782 at commit [`c7b81d2`](https://github.com/apache/spark/commit/c7b81d24f3f19de202bf82ab598efd41efd38bfa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641905245
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642621864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] delete duplicate testcase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-641905245
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642455277
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on pull request #28782:
URL: https://github.com/apache/spark/pull/28782#issuecomment-642389039
have adjusted test case order and rename test result file to look more pretty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28782: [SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28782:
URL: https://github.com/apache/spark/pull/28782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org