You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Guillaume Nodet <gn...@gmail.com> on 2012/06/07 17:10:52 UTC
[VOTE] Release SSHd 0.7.0
I've uploaded a release at
https://repository.apache.org/content/repositories/orgapachemina-201/
The release notes are available at
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
The vote will be opened for at least 72 hours. Please review and vote.
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [CANCEL] [VOTE] Release SSHd 0.7.0
Posted by Guillaume Nodet <gn...@gmail.com>.
I've fixed it that way. Please check the new assemblies i've uploaded
with pointers in the new vote thread.
On Mon, Jun 11, 2012 at 12:15 PM, sebb <se...@gmail.com> wrote:
> On 11 June 2012 08:06, Guillaume Nodet <gn...@gmail.com> wrote:
>> Cancelling this vote. I'll fix the two missing ASL headers and
>> enhance the notice file to precise that this only apply to the binary
>> distribution (I don't really want to mess with the whole assembly at
>> that point).
>
> Sorry, but I don't think that is acceptable.
> The NOTICE file must be as small as possible; it should not contain
> conditional entries.
>
> It's pretty easy to add a second NOTICE file for the binary archives
> somewhere else in the source tree, and then reference it in the
> assembly descriptor.
>
>> I'll recut a new release asap.
>>
>> On Thu, Jun 7, 2012 at 5:10 PM, Guillaume Nodet <gn...@gmail.com> wrote:
>>> I've uploaded a release at
>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>
>>> The release notes are available at
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>
>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> FuseSource, Integration everywhere
>>> http://fusesource.com
>>
>>
>>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> FuseSource, Integration everywhere
>> http://fusesource.com
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [CANCEL] [VOTE] Release SSHd 0.7.0
Posted by sebb <se...@gmail.com>.
On 11 June 2012 08:06, Guillaume Nodet <gn...@gmail.com> wrote:
> Cancelling this vote. I'll fix the two missing ASL headers and
> enhance the notice file to precise that this only apply to the binary
> distribution (I don't really want to mess with the whole assembly at
> that point).
Sorry, but I don't think that is acceptable.
The NOTICE file must be as small as possible; it should not contain
conditional entries.
It's pretty easy to add a second NOTICE file for the binary archives
somewhere else in the source tree, and then reference it in the
assembly descriptor.
> I'll recut a new release asap.
>
> On Thu, Jun 7, 2012 at 5:10 PM, Guillaume Nodet <gn...@gmail.com> wrote:
>> I've uploaded a release at
>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>
>> The release notes are available at
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>
>> The vote will be opened for at least 72 hours. Please review and vote.
>>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> FuseSource, Integration everywhere
>> http://fusesource.com
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com
[CANCEL] [VOTE] Release SSHd 0.7.0
Posted by Guillaume Nodet <gn...@gmail.com>.
Cancelling this vote. I'll fix the two missing ASL headers and
enhance the notice file to precise that this only apply to the binary
distribution (I don't really want to mess with the whole assembly at
that point). I'll recut a new release asap.
On Thu, Jun 7, 2012 at 5:10 PM, Guillaume Nodet <gn...@gmail.com> wrote:
> I've uploaded a release at
> https://repository.apache.org/content/repositories/orgapachemina-201/
>
> The release notes are available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>
> The vote will be opened for at least 72 hours. Please review and vote.
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Julien Vermillard <jv...@gmail.com>.
On Thu, Jun 7, 2012 at 5:10 PM, Guillaume Nodet <gn...@gmail.com> wrote:
> I've uploaded a release at
> https://repository.apache.org/content/repositories/orgapachemina-201/
>
> The release notes are available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>
> The vote will be opened for at least 72 hours. Please review and vote.
+1 for me
Julien
Re: [VOTE] Release SSHd 0.7.0
Posted by Alex Karasulu <ak...@apache.org>.
Looking at the release notes there appears to be some critical fixes.
+1
However note that I have not had a chance to verify the correctness of the
release, nor have I tested it.
On Thu, Jun 7, 2012 at 6:10 PM, Guillaume Nodet <gn...@gmail.com> wrote:
> I've uploaded a release at
> https://repository.apache.org/content/repositories/orgapachemina-201/
>
> The release notes are available at
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>
> The vote will be opened for at least 72 hours. Please review and vote.
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com
>
--
Best Regards,
-- Alex
Re: [VOTE] Release SSHd 0.7.0
Posted by sebb <se...@gmail.com>.
On 8 June 2012 16:48, sebb <se...@gmail.com> wrote:
> On 8 June 2012 10:37, Guillaume Nodet <gn...@gmail.com> wrote:
>> On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
>>> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>>>> I've uploaded a release at
>>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>>
>>>> The release notes are available at
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>>
>>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>
>>> Where is the SVN tag?
>>
>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>
> Ideally that should have an RC suffix in case the RC fails and has to be redone.
Two files don't have AL headers:
sshd-core/src/main/java/org/apache/sshd/agent/SshAgentConstants.java
sshd-core/src/test/java/org/apache/sshd/util/BogusChannel.java
> Otherwise the tag is not immutable.
>
>>>
>>> KEYS file?
>>
>> http://svn.apache.org/repos/asf/mina/KEYS
>>
>>>
>>> -1
>>>
>>> The NOTICE file in the source archive references code that is not
>>> actually included.
>>
>> Those are notices on the main dependencies, especially those inside
>> the binary distribution. This is slightly over protective, but erring
>> on the good side is better.
>
> It's not good to claim that a release contains code when it does not.
>
> The NOTICE file is for *required* notices only.
> The dependency entries are obviously not required if they are not present.
>
> The contents of NOTICE files are generally transitive, so it's vital
> that they are accurate.
>
>>>
>>>> --
>>>> ------------------------
>>>> Guillaume Nodet
>>>> ------------------------
>>>> Blog: http://gnodet.blogspot.com/
>>>> ------------------------
>>>> FuseSource, Integration everywhere
>>>> http://fusesource.com
>>
>>
>>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> FuseSource, Integration everywhere
>> http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 6/9/12 7:45 AM, Julien Vermillard a écrit :
> On Fri, Jun 8, 2012 at 6:43 PM, sebb<se...@gmail.com> wrote:
>> On 8 June 2012 17:23, Guillaume Nodet<gn...@gmail.com> wrote:
>>> On Fri, Jun 8, 2012 at 6:09 PM, sebb<se...@gmail.com> wrote:
>>>> On 8 June 2012 17:00, Guillaume Nodet<gn...@gmail.com> wrote:
>>>>> On Fri, Jun 8, 2012 at 5:48 PM, sebb<se...@gmail.com> wrote:
>>>>>> On 8 June 2012 10:37, Guillaume Nodet<gn...@gmail.com> wrote:
>>>>>>> On Fri, Jun 8, 2012 at 11:25 AM, sebb<se...@gmail.com> wrote:
>>>>>>>> On 7 June 2012 16:10, Guillaume Nodet<gn...@gmail.com> wrote:
>>>>>>>>> I've uploaded a release at
>>>>>>>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>>>>>>>
>>>>>>>>> The release notes are available at
>>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>>>>>>>
>>>>>>>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>>>>>> Where is the SVN tag?
>>>>>>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>>>>>> Ideally that should have an RC suffix in case the RC fails and has to be redone.
>>>>>> Otherwise the tag is not immutable.
>>>>>>
>>>>> That's up to the project to decide. Over the 6 releases I've done on
>>>>> sshd, this had not happened.
>>>> In that case, it's best to include the tag and revision in RC votes.
>>>> Otherwise one cannot trace provenance easily.
>>>>
>>>>> When it did happened in mina was mostly pre-major releases. SSHD is
>>>>> still in< 1.0 and I don't think we need to cut RC for minor releases.
>>>>> Immutable tags means no one should ever change those. But that's only
>>>>> true after the release has been voted.
>>>>> At least, that's what I've seen on the number of releases I did or
>>>>> voted on at the ASF over the 10 projects and last 7 years.
>>>>> And in all cases, each PMC has its own rules, and it does not seem to
>>>>> be the case here.
>>>>>
>>>>> Also, when using maven, you can't just rename a version. It just does
>>>>> not work for several reasons, one of them being that the version is
>>>>> actually inside the jars at several places.
>>>> It's perfectly possible to use RCn suffices with Maven projects.
>>>> Commons (and HttpComponents) do that all the time.
>>> I didn't say it's not possible, but you can't just rename the jars,
>> No need to rename the jar.
>> The jar does not need to have the RC suffix, just the tag.
>>
> Well we release like that since year in MINA, I don't think a tag RC
> prefix worth a veto.
> You plan to remove your veto if the NOTICE file and the licence header
> are fixed ?
a -1 on a release is, so to speak, not a veto. But still, if the N&L
files are not correct, that needs to be addressed.
Let's discuss about the releases on an other thread.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Julien Vermillard <jv...@gmail.com>.
On Fri, Jun 8, 2012 at 6:43 PM, sebb <se...@gmail.com> wrote:
> On 8 June 2012 17:23, Guillaume Nodet <gn...@gmail.com> wrote:
>> On Fri, Jun 8, 2012 at 6:09 PM, sebb <se...@gmail.com> wrote:
>>> On 8 June 2012 17:00, Guillaume Nodet <gn...@gmail.com> wrote:
>>>> On Fri, Jun 8, 2012 at 5:48 PM, sebb <se...@gmail.com> wrote:
>>>>> On 8 June 2012 10:37, Guillaume Nodet <gn...@gmail.com> wrote:
>>>>>> On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
>>>>>>> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>>>>>>>> I've uploaded a release at
>>>>>>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>>>>>>
>>>>>>>> The release notes are available at
>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>>>>>>
>>>>>>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>>>>>
>>>>>>> Where is the SVN tag?
>>>>>>
>>>>>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>>>>>
>>>>> Ideally that should have an RC suffix in case the RC fails and has to be redone.
>>>>> Otherwise the tag is not immutable.
>>>>>
>>>>
>>>> That's up to the project to decide. Over the 6 releases I've done on
>>>> sshd, this had not happened.
>>>
>>> In that case, it's best to include the tag and revision in RC votes.
>>> Otherwise one cannot trace provenance easily.
>>>
>>>> When it did happened in mina was mostly pre-major releases. SSHD is
>>>> still in < 1.0 and I don't think we need to cut RC for minor releases.
>>>> Immutable tags means no one should ever change those. But that's only
>>>> true after the release has been voted.
>>>> At least, that's what I've seen on the number of releases I did or
>>>> voted on at the ASF over the 10 projects and last 7 years.
>>>> And in all cases, each PMC has its own rules, and it does not seem to
>>>> be the case here.
>>>>
>>>> Also, when using maven, you can't just rename a version. It just does
>>>> not work for several reasons, one of them being that the version is
>>>> actually inside the jars at several places.
>>>
>>> It's perfectly possible to use RCn suffices with Maven projects.
>>> Commons (and HttpComponents) do that all the time.
>>
>> I didn't say it's not possible, but you can't just rename the jars,
>
> No need to rename the jar.
> The jar does not need to have the RC suffix, just the tag.
>
Well we release like that since year in MINA, I don't think a tag RC
prefix worth a veto.
You plan to remove your veto if the NOTICE file and the licence header
are fixed ?
>> you'll have to the release again when you want to get rid of the
>> So I don't really see the benefit since you have to two at least 2
>> releases each time.
>> Usually, when a release fail (such as this one, as I need to cancel it
>> to add the missing headers), I delete the tag, drop the staging repo,
>> and try again.
>
>>>
>>>>>>>
>>>>>>> KEYS file?
>>>>>>
>>>>>> http://svn.apache.org/repos/asf/mina/KEYS
>>>>>>
>>>>>>>
>>>>>>> -1
>>>>>>>
>>>>>>> The NOTICE file in the source archive references code that is not
>>>>>>> actually included.
>>>>>>
>>>>>> Those are notices on the main dependencies, especially those inside
>>>>>> the binary distribution. This is slightly over protective, but erring
>>>>>> on the good side is better.
>>>>>
>>>>> It's not good to claim that a release contains code when it does not.
>>>>>
>>>>> The NOTICE file is for *required* notices only.
>>>>> The dependency entries are obviously not required if they are not present.
>>>>>
>>>>> The contents of NOTICE files are generally transitive, so it's vital
>>>>> that they are accurate.
>>>>
>>>>
>>>> Yeah, that's not ideal I agree, but I'm not even sure how easily we
>>>> can change that atm.
>>>> I mean both distributions are generated in the same maven project and
>>>> they do use the same input afaik.
Re: [VOTE] Release SSHd 0.7.0
Posted by sebb <se...@gmail.com>.
On 8 June 2012 17:23, Guillaume Nodet <gn...@gmail.com> wrote:
> On Fri, Jun 8, 2012 at 6:09 PM, sebb <se...@gmail.com> wrote:
>> On 8 June 2012 17:00, Guillaume Nodet <gn...@gmail.com> wrote:
>>> On Fri, Jun 8, 2012 at 5:48 PM, sebb <se...@gmail.com> wrote:
>>>> On 8 June 2012 10:37, Guillaume Nodet <gn...@gmail.com> wrote:
>>>>> On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
>>>>>> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>>>>>>> I've uploaded a release at
>>>>>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>>>>>
>>>>>>> The release notes are available at
>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>>>>>
>>>>>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>>>>
>>>>>> Where is the SVN tag?
>>>>>
>>>>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>>>>
>>>> Ideally that should have an RC suffix in case the RC fails and has to be redone.
>>>> Otherwise the tag is not immutable.
>>>>
>>>
>>> That's up to the project to decide. Over the 6 releases I've done on
>>> sshd, this had not happened.
>>
>> In that case, it's best to include the tag and revision in RC votes.
>> Otherwise one cannot trace provenance easily.
>>
>>> When it did happened in mina was mostly pre-major releases. SSHD is
>>> still in < 1.0 and I don't think we need to cut RC for minor releases.
>>> Immutable tags means no one should ever change those. But that's only
>>> true after the release has been voted.
>>> At least, that's what I've seen on the number of releases I did or
>>> voted on at the ASF over the 10 projects and last 7 years.
>>> And in all cases, each PMC has its own rules, and it does not seem to
>>> be the case here.
>>>
>>> Also, when using maven, you can't just rename a version. It just does
>>> not work for several reasons, one of them being that the version is
>>> actually inside the jars at several places.
>>
>> It's perfectly possible to use RCn suffices with Maven projects.
>> Commons (and HttpComponents) do that all the time.
>
> I didn't say it's not possible, but you can't just rename the jars,
No need to rename the jar.
The jar does not need to have the RC suffix, just the tag.
> you'll have to the release again when you want to get rid of the rc.
> So I don't really see the benefit since you have to two at least 2
> releases each time.
> Usually, when a release fail (such as this one, as I need to cancel it
> to add the missing headers), I delete the tag, drop the staging repo,
> and try again.
>>
>>>>>>
>>>>>> KEYS file?
>>>>>
>>>>> http://svn.apache.org/repos/asf/mina/KEYS
>>>>>
>>>>>>
>>>>>> -1
>>>>>>
>>>>>> The NOTICE file in the source archive references code that is not
>>>>>> actually included.
>>>>>
>>>>> Those are notices on the main dependencies, especially those inside
>>>>> the binary distribution. This is slightly over protective, but erring
>>>>> on the good side is better.
>>>>
>>>> It's not good to claim that a release contains code when it does not.
>>>>
>>>> The NOTICE file is for *required* notices only.
>>>> The dependency entries are obviously not required if they are not present.
>>>>
>>>> The contents of NOTICE files are generally transitive, so it's vital
>>>> that they are accurate.
>>>
>>>
>>> Yeah, that's not ideal I agree, but I'm not even sure how easily we
>>> can change that atm.
>>> I mean both distributions are generated in the same maven project and
>>> they do use the same input afaik.
>>>
>>>>
>>>>>>
>>>>>>> --
>>>>>>> ------------------------
>>>>>>> Guillaume Nodet
>>>>>>> ------------------------
>>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>>> ------------------------
>>>>>>> FuseSource, Integration everywhere
>>>>>>> http://fusesource.com
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> ------------------------
>>>>> Guillaume Nodet
>>>>> ------------------------
>>>>> Blog: http://gnodet.blogspot.com/
>>>>> ------------------------
>>>>> FuseSource, Integration everywhere
>>>>> http://fusesource.com
>>>
>>>
>>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> FuseSource, Integration everywhere
>>> http://fusesource.com
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Guillaume Nodet <gn...@gmail.com>.
On Fri, Jun 8, 2012 at 6:09 PM, sebb <se...@gmail.com> wrote:
> On 8 June 2012 17:00, Guillaume Nodet <gn...@gmail.com> wrote:
>> On Fri, Jun 8, 2012 at 5:48 PM, sebb <se...@gmail.com> wrote:
>>> On 8 June 2012 10:37, Guillaume Nodet <gn...@gmail.com> wrote:
>>>> On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
>>>>> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>>>>>> I've uploaded a release at
>>>>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>>>>
>>>>>> The release notes are available at
>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>>>>
>>>>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>>>
>>>>> Where is the SVN tag?
>>>>
>>>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>>>
>>> Ideally that should have an RC suffix in case the RC fails and has to be redone.
>>> Otherwise the tag is not immutable.
>>>
>>
>> That's up to the project to decide. Over the 6 releases I've done on
>> sshd, this had not happened.
>
> In that case, it's best to include the tag and revision in RC votes.
> Otherwise one cannot trace provenance easily.
>
>> When it did happened in mina was mostly pre-major releases. SSHD is
>> still in < 1.0 and I don't think we need to cut RC for minor releases.
>> Immutable tags means no one should ever change those. But that's only
>> true after the release has been voted.
>> At least, that's what I've seen on the number of releases I did or
>> voted on at the ASF over the 10 projects and last 7 years.
>> And in all cases, each PMC has its own rules, and it does not seem to
>> be the case here.
>>
>> Also, when using maven, you can't just rename a version. It just does
>> not work for several reasons, one of them being that the version is
>> actually inside the jars at several places.
>
> It's perfectly possible to use RCn suffices with Maven projects.
> Commons (and HttpComponents) do that all the time.
I didn't say it's not possible, but you can't just rename the jars,
you'll have to the release again when you want to get rid of the rc.
So I don't really see the benefit since you have to two at least 2
releases each time.
Usually, when a release fail (such as this one, as I need to cancel it
to add the missing headers), I delete the tag, drop the staging repo,
and try again.
>
>>>>>
>>>>> KEYS file?
>>>>
>>>> http://svn.apache.org/repos/asf/mina/KEYS
>>>>
>>>>>
>>>>> -1
>>>>>
>>>>> The NOTICE file in the source archive references code that is not
>>>>> actually included.
>>>>
>>>> Those are notices on the main dependencies, especially those inside
>>>> the binary distribution. This is slightly over protective, but erring
>>>> on the good side is better.
>>>
>>> It's not good to claim that a release contains code when it does not.
>>>
>>> The NOTICE file is for *required* notices only.
>>> The dependency entries are obviously not required if they are not present.
>>>
>>> The contents of NOTICE files are generally transitive, so it's vital
>>> that they are accurate.
>>
>>
>> Yeah, that's not ideal I agree, but I'm not even sure how easily we
>> can change that atm.
>> I mean both distributions are generated in the same maven project and
>> they do use the same input afaik.
>>
>>>
>>>>>
>>>>>> --
>>>>>> ------------------------
>>>>>> Guillaume Nodet
>>>>>> ------------------------
>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>> ------------------------
>>>>>> FuseSource, Integration everywhere
>>>>>> http://fusesource.com
>>>>
>>>>
>>>>
>>>> --
>>>> ------------------------
>>>> Guillaume Nodet
>>>> ------------------------
>>>> Blog: http://gnodet.blogspot.com/
>>>> ------------------------
>>>> FuseSource, Integration everywhere
>>>> http://fusesource.com
>>
>>
>>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> FuseSource, Integration everywhere
>> http://fusesource.com
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by sebb <se...@gmail.com>.
On 8 June 2012 17:00, Guillaume Nodet <gn...@gmail.com> wrote:
> On Fri, Jun 8, 2012 at 5:48 PM, sebb <se...@gmail.com> wrote:
>> On 8 June 2012 10:37, Guillaume Nodet <gn...@gmail.com> wrote:
>>> On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
>>>> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>>>>> I've uploaded a release at
>>>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>>>
>>>>> The release notes are available at
>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>>>
>>>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>>
>>>> Where is the SVN tag?
>>>
>>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>>
>> Ideally that should have an RC suffix in case the RC fails and has to be redone.
>> Otherwise the tag is not immutable.
>>
>
> That's up to the project to decide. Over the 6 releases I've done on
> sshd, this had not happened.
In that case, it's best to include the tag and revision in RC votes.
Otherwise one cannot trace provenance easily.
> When it did happened in mina was mostly pre-major releases. SSHD is
> still in < 1.0 and I don't think we need to cut RC for minor releases.
> Immutable tags means no one should ever change those. But that's only
> true after the release has been voted.
> At least, that's what I've seen on the number of releases I did or
> voted on at the ASF over the 10 projects and last 7 years.
> And in all cases, each PMC has its own rules, and it does not seem to
> be the case here.
>
> Also, when using maven, you can't just rename a version. It just does
> not work for several reasons, one of them being that the version is
> actually inside the jars at several places.
It's perfectly possible to use RCn suffices with Maven projects.
Commons (and HttpComponents) do that all the time.
>>>>
>>>> KEYS file?
>>>
>>> http://svn.apache.org/repos/asf/mina/KEYS
>>>
>>>>
>>>> -1
>>>>
>>>> The NOTICE file in the source archive references code that is not
>>>> actually included.
>>>
>>> Those are notices on the main dependencies, especially those inside
>>> the binary distribution. This is slightly over protective, but erring
>>> on the good side is better.
>>
>> It's not good to claim that a release contains code when it does not.
>>
>> The NOTICE file is for *required* notices only.
>> The dependency entries are obviously not required if they are not present.
>>
>> The contents of NOTICE files are generally transitive, so it's vital
>> that they are accurate.
>
>
> Yeah, that's not ideal I agree, but I'm not even sure how easily we
> can change that atm.
> I mean both distributions are generated in the same maven project and
> they do use the same input afaik.
>
>>
>>>>
>>>>> --
>>>>> ------------------------
>>>>> Guillaume Nodet
>>>>> ------------------------
>>>>> Blog: http://gnodet.blogspot.com/
>>>>> ------------------------
>>>>> FuseSource, Integration everywhere
>>>>> http://fusesource.com
>>>
>>>
>>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> FuseSource, Integration everywhere
>>> http://fusesource.com
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Guillaume Nodet <gn...@gmail.com>.
On Fri, Jun 8, 2012 at 5:48 PM, sebb <se...@gmail.com> wrote:
> On 8 June 2012 10:37, Guillaume Nodet <gn...@gmail.com> wrote:
>> On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
>>> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>>>> I've uploaded a release at
>>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>>
>>>> The release notes are available at
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>>
>>>> The vote will be opened for at least 72 hours. Please review and vote.
>>>
>>> Where is the SVN tag?
>>
>> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>
> Ideally that should have an RC suffix in case the RC fails and has to be redone.
> Otherwise the tag is not immutable.
>
That's up to the project to decide. Over the 6 releases I've done on
sshd, this had not happened.
When it did happened in mina was mostly pre-major releases. SSHD is
still in < 1.0 and I don't think we need to cut RC for minor releases.
Immutable tags means no one should ever change those. But that's only
true after the release has been voted.
At least, that's what I've seen on the number of releases I did or
voted on at the ASF over the 10 projects and last 7 years.
And in all cases, each PMC has its own rules, and it does not seem to
be the case here.
Also, when using maven, you can't just rename a version. It just does
not work for several reasons, one of them being that the version is
actually inside the jars at several places.
>>>
>>> KEYS file?
>>
>> http://svn.apache.org/repos/asf/mina/KEYS
>>
>>>
>>> -1
>>>
>>> The NOTICE file in the source archive references code that is not
>>> actually included.
>>
>> Those are notices on the main dependencies, especially those inside
>> the binary distribution. This is slightly over protective, but erring
>> on the good side is better.
>
> It's not good to claim that a release contains code when it does not.
>
> The NOTICE file is for *required* notices only.
> The dependency entries are obviously not required if they are not present.
>
> The contents of NOTICE files are generally transitive, so it's vital
> that they are accurate.
Yeah, that's not ideal I agree, but I'm not even sure how easily we
can change that atm.
I mean both distributions are generated in the same maven project and
they do use the same input afaik.
>
>>>
>>>> --
>>>> ------------------------
>>>> Guillaume Nodet
>>>> ------------------------
>>>> Blog: http://gnodet.blogspot.com/
>>>> ------------------------
>>>> FuseSource, Integration everywhere
>>>> http://fusesource.com
>>
>>
>>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> FuseSource, Integration everywhere
>> http://fusesource.com
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by sebb <se...@gmail.com>.
On 8 June 2012 10:37, Guillaume Nodet <gn...@gmail.com> wrote:
> On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
>> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>>> I've uploaded a release at
>>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>>
>>> The release notes are available at
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>>
>>> The vote will be opened for at least 72 hours. Please review and vote.
>>
>> Where is the SVN tag?
>
> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
Ideally that should have an RC suffix in case the RC fails and has to be redone.
Otherwise the tag is not immutable.
>>
>> KEYS file?
>
> http://svn.apache.org/repos/asf/mina/KEYS
>
>>
>> -1
>>
>> The NOTICE file in the source archive references code that is not
>> actually included.
>
> Those are notices on the main dependencies, especially those inside
> the binary distribution. This is slightly over protective, but erring
> on the good side is better.
It's not good to claim that a release contains code when it does not.
The NOTICE file is for *required* notices only.
The dependency entries are obviously not required if they are not present.
The contents of NOTICE files are generally transitive, so it's vital
that they are accurate.
>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> FuseSource, Integration everywhere
>>> http://fusesource.com
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Emmanuel Lécharny <el...@gmail.com>.
ok, I switch to a +1
I had some bad jars in my maven repository. Everythingis now ok.
Le 6/8/12 7:22 PM, Guillaume Nodet a écrit :
> Are you sure your slf4j jar in your local maven repo is valid ?
> Could you try deleting it and rebuild ?
>
> On Fri, Jun 8, 2012 at 6:47 PM, Emmanuel Lécharny<el...@gmail.com> wrote:
>> -1
>>
>> checked out the project :
>>
>> $ svn co https://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0
>> $ cd sshd-0.7.0/
>> $ mvn clean install
>> ...
>> [INFO] Apache Mina SSHD .................................. SUCCESS [1.919s]
>> [INFO] Apache Mina SSHD :: Core .......................... FAILURE [3.904s]
>> [INFO] Apache Mina SSHD :: PAM ........................... SKIPPED
>> [INFO] Apache Mina SSHD :: Assembly ...................... SKIPPED
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] BUILD FAILURE
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] Total time: 6.178s
>> [INFO] Finished at: Fri Jun 08 18:45:47 CEST 2012
>> [INFO] Final Memory: 13M/81M
>> [INFO]
>> ------------------------------------------------------------------------
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile
>> (default-compile) on project sshd-core: Compilation failure: Compilation
>> failure:
>> [ERROR]
>> /Users/elecharny/mina/sshd/sshd-0.7.0/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java:[31,16]
>> package org.slf4j does not exist
>> [ERROR]
>> [ERROR]
>> /Users/elecharny/mina/sshd/sshd-0.7.0/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java:[32,16]
>> package org.slf4j does not exist
>> [ERROR]
>>
>>
>> --
>> Regards,
>> Cordialement,
>> Emmanuel Lécharny
>> www.iktek.com
>>
>
>
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Guillaume Nodet <gn...@gmail.com>.
Are you sure your slf4j jar in your local maven repo is valid ?
Could you try deleting it and rebuild ?
On Fri, Jun 8, 2012 at 6:47 PM, Emmanuel Lécharny <el...@gmail.com> wrote:
> -1
>
> checked out the project :
>
> $ svn co https://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0
> $ cd sshd-0.7.0/
> $ mvn clean install
> ...
> [INFO] Apache Mina SSHD .................................. SUCCESS [1.919s]
> [INFO] Apache Mina SSHD :: Core .......................... FAILURE [3.904s]
> [INFO] Apache Mina SSHD :: PAM ........................... SKIPPED
> [INFO] Apache Mina SSHD :: Assembly ...................... SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 6.178s
> [INFO] Finished at: Fri Jun 08 18:45:47 CEST 2012
> [INFO] Final Memory: 13M/81M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile
> (default-compile) on project sshd-core: Compilation failure: Compilation
> failure:
> [ERROR]
> /Users/elecharny/mina/sshd/sshd-0.7.0/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java:[31,16]
> package org.slf4j does not exist
> [ERROR]
> [ERROR]
> /Users/elecharny/mina/sshd/sshd-0.7.0/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java:[32,16]
> package org.slf4j does not exist
> [ERROR]
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Emmanuel Lécharny <el...@gmail.com>.
-1
checked out the project :
$ svn co https://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0
$ cd sshd-0.7.0/
$ mvn clean install
...
[INFO] Apache Mina SSHD .................................. SUCCESS [1.919s]
[INFO] Apache Mina SSHD :: Core .......................... FAILURE [3.904s]
[INFO] Apache Mina SSHD :: PAM ........................... SKIPPED
[INFO] Apache Mina SSHD :: Assembly ...................... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 6.178s
[INFO] Finished at: Fri Jun 08 18:45:47 CEST 2012
[INFO] Final Memory: 13M/81M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile
(default-compile) on project sshd-core: Compilation failure: Compilation
failure:
[ERROR]
/Users/elecharny/mina/sshd/sshd-0.7.0/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java:[31,16]
package org.slf4j does not exist
[ERROR]
[ERROR]
/Users/elecharny/mina/sshd/sshd-0.7.0/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java:[32,16]
package org.slf4j does not exist
[ERROR]
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [VOTE] Release SSHd 0.7.0
Posted by Guillaume Nodet <gn...@gmail.com>.
On Fri, Jun 8, 2012 at 11:25 AM, sebb <se...@gmail.com> wrote:
> On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
>> I've uploaded a release at
>> https://repository.apache.org/content/repositories/orgapachemina-201/
>>
>> The release notes are available at
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>>
>> The vote will be opened for at least 72 hours. Please review and vote.
>
> Where is the SVN tag?
http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/
>
> KEYS file?
http://svn.apache.org/repos/asf/mina/KEYS
>
> -1
>
> The NOTICE file in the source archive references code that is not
> actually included.
Those are notices on the main dependencies, especially those inside
the binary distribution. This is slightly over protective, but erring
on the good side is better.
>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> FuseSource, Integration everywhere
>> http://fusesource.com
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [VOTE] Release SSHd 0.7.0
Posted by sebb <se...@gmail.com>.
On 7 June 2012 16:10, Guillaume Nodet <gn...@gmail.com> wrote:
> I've uploaded a release at
> https://repository.apache.org/content/repositories/orgapachemina-201/
>
> The release notes are available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953
>
> The vote will be opened for at least 72 hours. Please review and vote.
Where is the SVN tag?
KEYS file?
-1
The NOTICE file in the source archive references code that is not
actually included.
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com