You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jay Zhuang (JIRA)" <ji...@apache.org> on 2018/06/30 00:44:00 UTC
[jira] [Commented] (CASSANDRA-14551) ReplicationAwareTokenAllocator
should block bootstrap if no replication number is set
[ https://issues.apache.org/jira/browse/CASSANDRA-14551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528420#comment-16528420 ]
Jay Zhuang commented on CASSANDRA-14551:
----------------------------------------
Here is the patch, please review:
| Branch | uTest | dTest |
| [14551-trunk|https://github.com/cooldoger/cassandra/tree/14551-trunk] | [!https://circleci.com/gh/cooldoger/cassandra/tree/14551-trunk.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/14551-trunk] | [!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/586/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/586/] |
cc. [~dikanggu]
> ReplicationAwareTokenAllocator should block bootstrap if no replication number is set
> -------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14551
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14551
> Project: Cassandra
> Issue Type: Bug
> Components: Configuration
> Reporter: Jay Zhuang
> Assignee: Jay Zhuang
> Priority: Minor
>
> We're using [ReplicationAwareTokenAllocator|https://www.datastax.com/dev/blog/token-allocation-algorithm]. When bootstrapping a new DC, the tokens are not well distributed. The problem is because the replication number is not set for the new DC before the bootstrap.
> I would suggest blocking the bootstrap if replication number is not set. It's unsafe to assume the default replicas is 1. Which also causes the following invalid stats:
> {noformat}
> WARN [main] 2018-06-29 17:30:55,696 TokenAllocation.java:69 - Replicated node load in datacenter before allocation max NaN min NaN stddev NaN
> WARN [main] 2018-06-29 17:30:55,696 TokenAllocation.java:70 - Replicated node load in datacenter after allocation max NaN min NaN stddev NaN
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org