You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/05/11 08:10:44 UTC
[GitHub] [hive] soumyakanti3578 opened a new pull request, #3280: HIVE-26191: Missing catalog name in GetTableRequest results in duplicate values in query level cache
soumyakanti3578 opened a new pull request, #3280:
URL: https://github.com/apache/hive/pull/3280
### What changes were proposed in this pull request?
Add catalog name as argument to `getValidWriteIdList` method
### Why are the changes needed?
Missing catalog results in query cache misses and duplicate cache entries
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Checked the cache entries manually by debugging various qtests like `cbo_query2.q`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3280: HIVE-26191: Missing catalog name in GetTableRequest results in duplicate values in query level cache
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on code in PR #3280:
URL: https://github.com/apache/hive/pull/3280#discussion_r870520711
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -2506,13 +2506,13 @@ private Map<Object, Object> getQueryCache() {
}
@Override
- protected String getValidWriteIdList(String dbName, String tblName) {
+ protected String getValidWriteIdList(String catName, String dbName, String tblName) {
Review Comment:
an alternate approach would be to replace arguments like this with a `TableName`...so that we move forward with that refactor and use that object more extensively;
I think bugs like this are simply just sideeffects of passing a set of strings together - and sometimes miss one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3280: HIVE-26191: Missing catalog name in GetTableRequest results in duplicate values in query level cache
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3280:
URL: https://github.com/apache/hive/pull/3280#issuecomment-1179834061
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3280: HIVE-26191: Missing catalog name in GetTableRequest results in duplicate values in query level cache
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3280: HIVE-26191: Missing catalog name in GetTableRequest results in duplicate values in query level cache
URL: https://github.com/apache/hive/pull/3280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org