You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/18 14:31:21 UTC

[GitHub] [incubator-kvrocks] PragmaTwice opened a new issue, #589: Improve version.h.in processing in CMake

PragmaTwice opened a new issue, #589:
URL: https://github.com/apache/incubator-kvrocks/issues/589

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   Now the generated version.h by CMake is not comsistent with the previous Makefiles.
   The version is now set in [CMakeLists.txt#L20](https://github.com/apache/incubator-kvrocks/blob/unstable/CMakeLists.txt#L20), we can remove it and read version in the Changelog file, so we do not need to change CMakeLists while a new version is released.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #589: Improve version.h.in processing in CMake

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #589:
URL: https://github.com/apache/incubator-kvrocks/issues/589#issuecomment-1131201230

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun closed issue #589: Improve `version.h.in` processing in CMake

Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #589: Improve `version.h.in` processing in CMake
URL: https://github.com/apache/incubator-kvrocks/issues/589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org