[GitHub] ddragosd commented on a change in pull request #4185: recreate http client on resume()

[GitBox <gi...@apache.org>]

ddragosd commented on a change in pull request #4185: recreate http client on resume()
URL: https://github.com/apache/incubator-openwhisk/pull/4185#discussion_r249162803
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/Container.scala
 ##########
 @@ -204,6 +209,17 @@ trait Container {
         RunResult(Interval(started, finished), response)
       }
   }
+  private def openConnections(timeout: FiniteDuration, maxConcurrent: Int) = {
+    if (Container.config.akkaClient) {
 
 Review comment:
   I forgot what we're still maintaining the Akka Client and the Apache Client, since the latter was found in https://github.com/apache/incubator-openwhisk/pull/3812 to perform poorly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services