solrj DocumentObjectBinder prints to stdout

[Ilan Rabinovitch <il...@fonz.net>]

Hello,

We recently noticed that the inject method of DocumentObjectBinder [1] 
in solr4j logs to standard out using System.out.println if any variables 
in the returned result have null value.


The system.out.println statement was added on 2009-07-14 as part of 
SOLR-1129.

This can get quite spammy on the console, and as its a System.out 
statement there is no method by which to configure it currently.

Should this be logging at the INFO/DEBUG level using slf4j instead?
I've opened SOLR-1417 to track this.


Thanks,
Ilan

[1] 
src/solrj/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java:316 
(r794144)

<T> void inject(T obj, SolrDocument sdoc) {
Object val = getFieldValue(sdoc);
if(val == null) { System.out.println("val null for "+ name); return; }



-- 
Ilan Rabinovitch
ilan@fonz.net

---
SCALE 8x: 2010 Southern California Linux Expo
Feb 19-21, 2010
Los Angeles, CA
http://www.socallinuxexpo.org

Re: solrj DocumentObjectBinder prints to stdout

[Noble Paul നോബിള്‍ नोब्ळ् <no...@corp.aol.com>]

I just removed it and checked it in.
Thanks

On Wed, Sep 9, 2009 at 8:12 AM, Ilan Rabinovitch<il...@fonz.net> wrote:
> Hello,
>
> We recently noticed that the inject method of DocumentObjectBinder [1] in
> solr4j logs to standard out using System.out.println if any variables in the
> returned result have null value.
>
>
> The system.out.println statement was added on 2009-07-14 as part of
> SOLR-1129.
>
> This can get quite spammy on the console, and as its a System.out statement
> there is no method by which to configure it currently.
>
> Should this be logging at the INFO/DEBUG level using slf4j instead?
> I've opened SOLR-1417 to track this.
>
>
> Thanks,
> Ilan
>
> [1]
> src/solrj/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java:316
> (r794144)
>
> <T> void inject(T obj, SolrDocument sdoc) {
> Object val = getFieldValue(sdoc);
> if(val == null) { System.out.println("val null for "+ name); return; }
>
>
>
> --
> Ilan Rabinovitch
> ilan@fonz.net
>
> ---
> SCALE 8x: 2010 Southern California Linux Expo
> Feb 19-21, 2010
> Los Angeles, CA
> http://www.socallinuxexpo.org
>
>



-- 
-----------------------------------------------------
Noble Paul | Principal Engineer| AOL | http://aol.com