[GitHub] [superset] lyndsiWilliams commented on a change in pull request #17758: feat(timeseries-chart): [WIP] add percentage threshold input control

[GitBox <gi...@apache.org>]

lyndsiWilliams commented on a change in pull request #17758:
URL: https://github.com/apache/superset/pull/17758#discussion_r771376263



##########
File path: superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
##########
@@ -49,8 +53,8 @@ describe('EchartsTimeseries tranformProps', () => {
   };
 
   it('should tranform chart props for viz', () => {
-    const chartProps = new ChartProps(chartPropsConfig);
-    expect(transformProps(chartProps)).toEqual(
+    const chartProps: unknown = new ChartProps(chartPropsConfig);

Review comment:
       There are [a few prop types described in this component](https://github.com/apache/superset/blob/6f8927209b80dc61ba14fc66ff94871b36a83321/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts#L32-L37), would any of those work here instead of `unknown`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org