[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11418: feat(explore): time picker enhancement

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #11418:
URL: https://github.com/apache/incubator-superset/pull/11418#discussion_r545311592



##########
File path: superset/charts/api.py
##########
@@ -997,3 +1001,56 @@ def import_(self) -> Response:
         except Exception as exc:  # pylint: disable=broad-except
             logger.exception("Import chart failed")
             return self.response_500(message=str(exc))
+
+    @expose("/time_range/", methods=["GET"])

Review comment:
       My question is do we need `@expose` decorator: https://flask-admin.readthedocs.io/en/latest/api/mod_base/#base-view. The decorator is used to create a `view`, but i feel what we need here is only an internal function `def time_range`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org