You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/15 21:12:06 UTC
Re: Review Request 71074: Added a test to ensure that roles with only
reservations are exposed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71074/
-----------------------------------------------------------
(Updated July 15, 2019, 9:12 p.m.)
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Changes
-------
- Pulled out into its own test.
Summary (updated)
-----------------
Added a test to ensure that roles with only reservations are exposed.
Bugs: MESOS-9888
https://issues.apache.org/jira/browse/MESOS-9888
Repository: mesos
Description
-------
This adds a test for MESOS-9888, to ensure that if a role has only
reservations associated with it, it gets exposed from /roles.
Diffs (updated)
-----
src/tests/role_tests.cpp 5066e419c68d362dcbb785ac803e9c5c7415032b
Diff: https://reviews.apache.org/r/71074/diff/2/
Changes: https://reviews.apache.org/r/71074/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71074: Added a test to ensure that roles with only
reservations are exposed.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71074/#review216623
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On July 15, 2019, 2:12 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71074/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 2:12 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-9888
> https://issues.apache.org/jira/browse/MESOS-9888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a test for MESOS-9888, to ensure that if a role has only
> reservations associated with it, it gets exposed from /roles.
>
>
> Diffs
> -----
>
> src/tests/role_tests.cpp 5066e419c68d362dcbb785ac803e9c5c7415032b
>
>
> Diff: https://reviews.apache.org/r/71074/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>