[GitHub] [trafficserver] serrislew commented on pull request #9620: Return current parent max retry count for parent proxy

["serrislew (via GitHub)" <gi...@apache.org>]

serrislew commented on PR #9620:
URL: https://github.com/apache/trafficserver/pull/9620#issuecomment-1520704850

   Maybe the docs need to be updated then since it seems like these configs are used for attempts before failing a request, not making the parent down. Or is that implied? 
   
   It seems like for the parents, there are 2 kinds of attempt limits: 1 for the connection attempts for a specific transaction before failing it and 1 for the connection attempts on a parent before making it unavailable. And from my previous comment, it seems like `proxy.config.http.connect_attempts_max_retries` for OS is used to determine how many attempts are needed before marking this origin dead, which is the latter attempt limit. If it's implied that after `proxy.config.http.parent_proxy.per_parent_connect_attempts` is reached and so we are done with this particular parent that we will mark it down, why do we have this separate config `proxy.config.http.parent_proxy.fail_threshold`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org