You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2008/10/28 22:26:44 UTC
[jira] Created: (QPID-1407) QMF generator doesn't build the
directory tree on Windows
QMF generator doesn't build the directory tree on Windows
---------------------------------------------------------
Key: QPID-1407
URL: https://issues.apache.org/jira/browse/QPID-1407
Project: Qpid
Issue Type: Bug
Components: Code Generator
Environment: Windows
Reporter: Steve Huston
Fix For: M4
The qpid/cpp/managementgen/qmf/generate.py code doesn't create the needed subdirectory tree for generated code the first time it's run on Windows. The reason is that the os.stat() function returns a different error for Windows than for Linux if the dir doesn't exist.
This patch fixes it:
Index: qmf/generate.py
===================================================================
--- qmf/generate.py (revision 708607)
+++ qmf/generate.py (working copy)
@@ -166,7 +166,7 @@
try:
mode = os.stat (path)[ST_MODE]
except OSError, (err,text):
- if err == ENOENT:
+ if err == ENOENT or err == ESRCH:
exists = False
else:
raise
Ok to commit this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1407) QMF generator doesn't build the
directory tree on Windows
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston resolved QPID-1407.
--------------------------------
Resolution: Fixed
Assignee: Steve Huston
Thanks very much for the quick review, Ted. Committed in svn revision 708703
> QMF generator doesn't build the directory tree on Windows
> ---------------------------------------------------------
>
> Key: QPID-1407
> URL: https://issues.apache.org/jira/browse/QPID-1407
> Project: Qpid
> Issue Type: Bug
> Components: Code Generator
> Environment: Windows
> Reporter: Steve Huston
> Assignee: Steve Huston
> Fix For: M4
>
>
> The qpid/cpp/managementgen/qmf/generate.py code doesn't create the needed subdirectory tree for generated code the first time it's run on Windows. The reason is that the os.stat() function returns a different error for Windows than for Linux if the dir doesn't exist.
> This patch fixes it:
> Index: qmf/generate.py
> ===================================================================
> --- qmf/generate.py (revision 708607)
> +++ qmf/generate.py (working copy)
> @@ -166,7 +166,7 @@
> try:
> mode = os.stat (path)[ST_MODE]
> except OSError, (err,text):
> - if err == ENOENT:
> + if err == ENOENT or err == ESRCH:
> exists = False
> else:
> raise
> Ok to commit this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1407) QMF generator doesn't build the
directory tree on Windows
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643344#action_12643344 ]
Ted Ross commented on QPID-1407:
--------------------------------
Steve,
Go ahead and commit. Thanks for the fix.
-Ted
> QMF generator doesn't build the directory tree on Windows
> ---------------------------------------------------------
>
> Key: QPID-1407
> URL: https://issues.apache.org/jira/browse/QPID-1407
> Project: Qpid
> Issue Type: Bug
> Components: Code Generator
> Environment: Windows
> Reporter: Steve Huston
> Fix For: M4
>
>
> The qpid/cpp/managementgen/qmf/generate.py code doesn't create the needed subdirectory tree for generated code the first time it's run on Windows. The reason is that the os.stat() function returns a different error for Windows than for Linux if the dir doesn't exist.
> This patch fixes it:
> Index: qmf/generate.py
> ===================================================================
> --- qmf/generate.py (revision 708607)
> +++ qmf/generate.py (working copy)
> @@ -166,7 +166,7 @@
> try:
> mode = os.stat (path)[ST_MODE]
> except OSError, (err,text):
> - if err == ENOENT:
> + if err == ENOENT or err == ESRCH:
> exists = False
> else:
> raise
> Ok to commit this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.