[jira] [Commented] (ZOOKEEPER-1847) Normalize line endings in repository

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851113#comment-13851113 ] 

Hadoop QA commented on ZOOKEEPER-1847:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12619189/zookeeper-1847_v1.patch
  against trunk revision 1551624.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 28 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1846//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1846//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1846//console

This message is automatically generated.

> Normalize line endings in repository
> ------------------------------------
>
>                 Key: ZOOKEEPER-1847
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1847
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 3.5.0
>
>         Attachments: zookeeper-1847_v1.patch
>
>
> It is good practice to have all the code in the repository use the same line endings (LF) so that patches can be applied normally. We can add a gitattributes file so that checked out code can still have platform dependent line endings. 
> More readings: 
> https://help.github.com/articles/dealing-with-line-endings
> http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)