[GitHub] wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

[GitBox <gi...@apache.org>]

wy96f commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout
URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259701428
 
 

 ##########
 File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
 ##########
 @@ -771,7 +771,11 @@ private void reconnectSessions(final RemotingConnection oldConnection,
       ((CoreRemotingConnection) connection).syncIDGeneratorSequence(((CoreRemotingConnection) oldConnection).getIDGeneratorSequence());
 
       for (ClientSessionInternal session : sessionsToFailover) {
-         session.handleFailover(connection, cause);
+         if (session.handleFailover(connection, cause)) {
+            connection.destroy();
 
 Review comment:
   We'll add test to simulate the scenario where reattach timeout. Just not sure the proper way to fix the problem:)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services