You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/06/18 09:20:31 UTC

[GitHub] [ignite] pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout

pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
URL: https://github.com/apache/ignite/pull/6490#discussion_r294692820
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformConfigurationUtils.java
 ##########
 @@ -622,6 +622,8 @@ public static void readIgniteConfiguration(BinaryRawReaderEx in, IgniteConfigura
         ClientListenerProtocolVersion ver) {
         if (in.readBoolean())
             cfg.setClientMode(in.readBoolean());
+        if (in.readBoolean())
 
 Review comment:
   As far as I remember, *nullable* properties should be protected with `in.readBoolean()` construct. We need to double check it with .NET contributors. Also, the added property should be added to a .NET configuration mirror `modules/platforms/dotnet/Apache.Ignite.Core/IgniteConfiguration.cs`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services