You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/04 13:17:57 UTC
[GitHub] [activemq-nms-api] lrushl commented on a change in pull request
#13: added SourceLink support
lrushl commented on a change in pull request #13: added SourceLink support
URL: https://github.com/apache/activemq-nms-api/pull/13#discussion_r403469213
##########
File path: src/nms-api/nms-api.csproj
##########
@@ -47,6 +47,24 @@ with the License. You may obtain a copy of the License at
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
</PropertyGroup>
+ <!-- SourceLink Start -->
+ <PropertyGroup>
+ <!-- Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
+ <PublishRepositoryUrl>true</PublishRepositoryUrl>
Review comment:
According to the documentation [PublishRepositoryUrl](https://github.com/dotnet/sourcelink/blob/master/docs/README.md#publishrepositoryurl) modifies the same `RepositoryUrl` property. The only difference is that it does this dynamically.
I agree that there is no sense to have them both.
I'd rather remove `PublishRepositoryUrl` and do not touch the existing one (with explicit value).
@Havret , please share your thoughts on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services