You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/18 14:53:50 UTC

[GitHub] [spark] zero323 commented on pull request #35558: [SPARK-38243][PYTHON][ML] Fix pyspark.ml.LogisticRegression.getThreshold error message logic

zero323 commented on pull request #35558:
URL: https://github.com/apache/spark/pull/35558#issuecomment-1044649241


   Thanks for the review @srowen.
   
   > Could you do a quick search to see if .join(ts) is called like this anywhere else?
   
   I did a quick sweep, but nothing popped out.
   
   In core, sql and ml errors like this should be already detected with inline hints, mllib is just not there yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org