You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Uwe Schindler <uw...@thetaphi.de> on 2009/10/01 00:19:08 UTC

RE: [jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

Oh we have to really convert this. We will erase all deprecated methods
soon.

 

I will look into this. The new QueryParser attributes API can also be done
by me. The current TokenStreams in analysis should be simple (just remove th
cast) :-) - Can you post a separate patch for contrib? I will go to bed now!

 

Thanks for your help!

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
 <http://www.thetaphi.de> http://www.thetaphi.de
eMail: uwe@thetaphi.de

  _____  

From: Robert Muir [mailto:rcmuir@gmail.com] 
Sent: Thursday, October 01, 2009 12:10 AM
To: java-dev@lucene.apache.org
Subject: Re: [jira] Updated: (LUCENE-1855) Change AttributeSource API to use
generics

 

uwe, somewhat related to attributes API... anyway I can trick you or Luis or
someone more familiar with QueryParsing into looking at
PrecedenceQueryParser under contrib/misc?

This still uses the old tokenstream next(Token) API!

I think for this one I don't feel comfortable trying to convert it... scared
to introduce bugs :)

On Wed, Sep 30, 2009 at 5:56 PM, Uwe Schindler <uw...@thetaphi.de> wrote:

Thanks...! I asked, because you know the tokenizers better :-)

 

Uwe

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
 <http://www.thetaphi.de> http://www.thetaphi.de
eMail: uwe@thetaphi.de

  _____  

From: Robert Muir [mailto:rcmuir@gmail.com] 
Sent: Wednesday, September 30, 2009 11:52 PM
To: java-dev@lucene.apache.org
Subject: Re: [jira] Updated: (LUCENE-1855) Change AttributeSource API to use
generics

 

Uwe, I can work on the contrib portion tonight (jira is not happy with me
right now)

On Wed, Sep 30, 2009 at 5:33 PM, Uwe Schindler (JIRA) <ji...@apache.org>
wrote:


    [
https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.pl
ugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1855:
----------------------------------

   Attachment: LUCENE-1855.patch

Some Javadoc additions, also change QueryParser.jj file.

Contrib and contrib queryparser was not converted. The new Queryparser would
also get cleaner without the unneeded casts.

I will commit this tomorrow, when JIRA hopefully works better.

Robert Muir: Do you have time to remove the casts from contrib?
Luis Alves: You can also update the new Queryparser to not cas the return of
getAttribute/addAttribute


> Change AttributeSource API to use generics
> ------------------------------------------
>
>                 Key: LUCENE-1855
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1855
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Michael Busch
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>

>         Attachments: AttributeSource.jad, LUCENE-1855.patch,
LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch

>
>
> The AttributeSource API will be easier to use with JDK 1.5 generics.
> Uwe, if you started working on a patch for this already feel free to
assign this to you.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org




-- 
Robert Muir
rcmuir@gmail.com




-- 
Robert Muir
rcmuir@gmail.com