You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/23 14:37:37 UTC
[GitHub] [incubator-nuttx] hartmannathan opened a new pull request, #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
hartmannathan opened a new pull request, #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177
## Summary
boards/arm/stm32/b-g474e-dpow1/README.txt:
Apparently `sudo` is required for `openocd` to FLASH-program the microcontroller properly.
## Impact
Improves documentation.
## Testing
This is how I got the nuttx image onto the board to test the above release as mentioned in my vote email for NuttX-11.0.0-RC2 on the incubator general mailing list: https://lists.apache.org/thread/zm62l2b21wpbbo1b1r12krpsvvm7rw2n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1257210672
Okay, squashed. Ready for merge if you're happy with it. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#discussion_r979293925
##########
boards/arm/stm32/b-g474e-dpow1/README.txt:
##########
@@ -52,7 +52,7 @@ Development Environment
* Build NuttX.
* Flash the code using:
- $ openocd -f interface/stlink.cfg -f target/stm32g4x.cfg -c init \
+ $ sudo openocd -f interface/stlink.cfg -f target/stm32g4x.cfg -c init \
Review Comment:
IMO such things like sudo should not be stated as it is very specific and user may run the system with root permissions already. But if that is convenient for copy pasting then I'm fine with that. I mean that some instructions state `apt install xxx` and other `sudo apt install xxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
Posted by GitBox <gi...@apache.org>.
btashton merged PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1256328380
> We should _not_ be encouraging people to use sudo here and instead should set the proper udev config
Do you have an example of how to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1256636444
> > We should _not_ be encouraging people to use sudo here and instead should set the proper udev config
>
> Do you have an example of how to do that?
I believe the steps from this guide seem enough to configure non-root usage of `openocd`:
https://forgge.github.io/theCore/guides/running-openocd-without-sudo.html#other-linux-distros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1257208645
@btashton, @gustavonihei, @pkarashchenko, thank you all for your input. The changes I just pushed offer the following compromise:
(1) Removed 'sudo' from the 'openocd' incantation shown.
(2) Added a note about configuring udev rules.
(3) Added a link to OpenOCD's upstream docs about that, as well as the very helpful link found by @gustavonihei (thanks!).
(4) Although I still mention the possibility of 'sudo', it is mentioned last and I specifically state that it is not encouraged.
Now it is up to the embedded developer to decide what is best in his or her own situation.
Please re-review if you can and let me know what you think! Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1257210254
One moment, I forgot to squash commits...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org