You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ulysses-you (via GitHub)" <gi...@apache.org> on 2023/03/02 03:26:19 UTC

[GitHub] [spark] ulysses-you commented on pull request #39624: [SPARK-42101][SQL] Introduce Materializable and MaterializableQueryStage for AQE framework

ulysses-you commented on PR #39624:
URL: https://github.com/apache/spark/pull/39624#issuecomment-1451242481

   @cloud-fan it seems the main concern is that, shall we make `Materializable` as first-class citizen in AQE framework ? if so, then all code place in AQE framework should use `Materializable` instead of `QueryStage`.
   
   In fact, I'm not sure it is fine. There are a lot of code name depend on query stage. e.g., `queryStagePreparationRules` -> `materializablePreparationRules`. It actually the developer api
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org