You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Chris Lombardi (JIRA)" <ji...@apache.org> on 2008/02/19 23:40:43 UTC
[jira] Created: (OFBIZ-1663) POS: All payment types allow change
to be made
POS: All payment types allow change to be made
------------------------------------------------
Key: OFBIZ-1663
URL: https://issues.apache.org/jira/browse/OFBIZ-1663
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/pos
Affects Versions: Release Branch 4.0
Reporter: Chris Lombardi
Priority: Minor
I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571748#action_12571748 ]
Chris Lombardi commented on OFBIZ-1663:
---------------------------------------
I haven't been able to reproduce this.
>From the error message, it sounds like the POS isn't able to create a split shipment when there are multiple payment types. Are there any special items in your POS that require a split shipment?
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571742#action_12571742 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Hi Chris,
I commited a slightly modified (i10n) version of your patch in trunk revision: 630437 and release4.0
But I do not close this issue since I got the error below while trying to pay 1st with cash and then with a check. Not sure it's related. I have no more time now so feel free to close this issue and open a new one if you think it's needed. Thanks
2008-02-23 14:56:32,906 (Thread-89) [ PosButton.java:125:ERROR]
---- exception report ----------------------------------------------------------
Button invocation exception - ALT.payFinish
Exception: org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
Message: null
---- stack trace ---------------------------------------------------------------
org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:216)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
java.lang.reflect.InvocationTargetException
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
Caused by: org.ofbiz.base.util.GeneralRuntimeException: Split Payment Preference per Ship Group does not yet support multiple Payment Methods
org.ofbiz.order.shoppingcart.ShoppingCart$CartPaymentInfo.makeOrderPaymentInfos(ShoppingCart.java:4527)
org.ofbiz.order.shoppingcart.ShoppingCart.makeAllOrderPaymentInfos(ShoppingCart.java:3588)
org.ofbiz.order.shoppingcart.ShoppingCart.makeCartMap(ShoppingCart.java:3825)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:572)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:545)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:763)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:306)
... 9 more
--------------------------------------------------------------------------------
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-1663) POS: All payment types allow change
to be made
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi reopened OFBIZ-1663:
-----------------------------------
So even after ofbiz-1706 has been fixed, you are still seeing this error? That's interesting.
I do plan on fixing this, I'm admittedly slow because I'm working on something else at the moment, but I will return. If you would like, assign it to me so it isn't cluttering up your list.
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588355#action_12588355 ]
Chris Lombardi commented on OFBIZ-1663:
---------------------------------------
Thanks SG! I must have skimmed past the references to 4.0. JLR, did you encounter this defect in 4.0 or trunk? That would explain why I wasn't able to reproduce it.
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571063#action_12571063 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Hi Chris,
Like everything in OFBiz it depends on good wills. But I think it's best to let people dealing with their own languages, the matter is sometimes rather complex...
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570992#action_12570992 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
In nobody see a problem with this patch I will commit it soon (with sligh modifications I guess)...
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571065#action_12571065 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Also, AFAIK, you d'ont need to provide other languages but at least default (english). Actually it was working well with properties files, seems to be some rare issues here an there since we use xml files (but maybe it's already solved, I don't thing a Jira issue has been opened for that).
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1663) POS: All payment types allow change
to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1663:
--------------------------------------
Assignee: Jacques Le Roux
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1663) POS: All payment types allow change
to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1663.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 4.0
You were right Chris it was related to OFBIZ-1706. So I close this issue even if I discovered that order are not put in the right status (completed) but stay in created status because of this error :
2008-04-12 20:26:03,562 (Thread-26) [ ServiceDispatcher.java:419:ERROR] Service Error [changeOrderStatus]: %Erreur : Ne peut pas changer le statut de la commande ; le statut ne peut pas Ûtre changÚ.%
2008-04-12 20:26:03,578 (Thread-26) [ TransactionUtil.java:255:ERROR]
---- exception report ----------------------------------------------------------
[TransactionUtil.rollback]
Exception: java.lang.Exception
Message: Stack Trace
---- stack trace ---------------------------------------------------------------
java.lang.Exception: Stack Trace
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:254)
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:236)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:423)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:211)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
org.ofbiz.order.order.OrderChangeHelper.orderStatusChanges(OrderChangeHelper.java:158)
org.ofbiz.order.order.OrderChangeHelper.completeOrder(OrderChangeHelper.java:121)
org.ofbiz.order.shoppingcart.CheckOutHelper.processPayment(CheckOutHelper.java:1063)
org.ofbiz.order.shoppingcart.CheckOutHelper.processPayment(CheckOutHelper.java:834)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:624)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:308)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
java.lang.reflect.Method.invoke(Unknown Source)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:120)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Unknown Source)
--------------------------------------------------------------------------------
2008-04-12 20:26:03,578 (Thread-26) [ TransactionUtil.java:265:INFO ] [TransactionUtil.rollback] transaction rolled back
2008-04-12 20:26:03,578 (Thread-26) [ ServiceDispatcher.java:467:DEBUG] Sync service [POSDispatcher/changeOrderStatus] finished in [94] milliseconds
2008-04-12 20:26:03,578 (Thread-26) [ OrderChangeHelper.java:160:ERROR] Problems adjusting order header status for order #RS10010
But as it does not prevent to create the invoice and I have not time to investigate further I close this issue. Maybe it's only because face-to-face is not considered and it assumes that the check is not yet received... If someone is annoyed by this simply open a new issue...
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571050#action_12571050 ]
Chris Lombardi commented on OFBIZ-1663:
---------------------------------------
BTW, what is the traditional ofbiz process for getting translations? Even as much as some of you are multilingual there are some rather exotic languages in there. Do we just go to babelfish and hope for the best?
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1663) POS: All payment types allow change
to be made
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1663:
----------------------------------
Attachment: ofbiz-1663.patch
This fixes the issue in the POS application. I don't think it should harm any other scenarios unless there are situations where people pay more than what is required. Are there?
Also, this adds a new error message. I left all the languages in english as I don't think anyone wants my translations. Mon Francais et autre langue e tres mal. :)
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588329#action_12588329 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Chris,
If you take care of it I will keep it on my list; to be aware when it will be time to review and hopefully commit,
Thanks
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1663) POS: All payment types
allow change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571742#action_12571742 ]
jacques.le.roux edited comment on OFBIZ-1663 at 2/23/08 6:03 AM:
-----------------------------------------------------------------
Hi Chris,
I commited a slightly modified (i10n) version of your patch in trunk revision: 630437 and release4.0 630438
But I do not close this issue since I got the error below while trying to pay 1st with cash and then with a check. Not sure it's related. I have no more time now so feel free to close this issue and open a new one if you think it's needed. Thanks
2008-02-23 14:56:32,906 (Thread-89) [ PosButton.java:125:ERROR]
---- exception report ----------------------------------------------------------
Button invocation exception - ALT.payFinish
Exception: org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
Message: null
---- stack trace ---------------------------------------------------------------
org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:216)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
java.lang.reflect.InvocationTargetException
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
Caused by: org.ofbiz.base.util.GeneralRuntimeException: Split Payment Preference per Ship Group does not yet support multiple Payment Methods
org.ofbiz.order.shoppingcart.ShoppingCart$CartPaymentInfo.makeOrderPaymentInfos(ShoppingCart.java:4527)
org.ofbiz.order.shoppingcart.ShoppingCart.makeAllOrderPaymentInfos(ShoppingCart.java:3588)
org.ofbiz.order.shoppingcart.ShoppingCart.makeCartMap(ShoppingCart.java:3825)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:572)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:545)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:763)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:306)
... 9 more
--------------------------------------------------------------------------------
was (Author: jacques.le.roux):
Hi Chris,
I commited a slightly modified (i10n) version of your patch in trunk revision: 630437 and release4.0
But I do not close this issue since I got the error below while trying to pay 1st with cash and then with a check. Not sure it's related. I have no more time now so feel free to close this issue and open a new one if you think it's needed. Thanks
2008-02-23 14:56:32,906 (Thread-89) [ PosButton.java:125:ERROR]
---- exception report ----------------------------------------------------------
Button invocation exception - ALT.payFinish
Exception: org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
Message: null
---- stack trace ---------------------------------------------------------------
org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:216)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
java.lang.reflect.InvocationTargetException
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
Caused by: org.ofbiz.base.util.GeneralRuntimeException: Split Payment Preference per Ship Group does not yet support multiple Payment Methods
org.ofbiz.order.shoppingcart.ShoppingCart$CartPaymentInfo.makeOrderPaymentInfos(ShoppingCart.java:4527)
org.ofbiz.order.shoppingcart.ShoppingCart.makeAllOrderPaymentInfos(ShoppingCart.java:3588)
org.ofbiz.order.shoppingcart.ShoppingCart.makeCartMap(ShoppingCart.java:3825)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:572)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:545)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:763)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:306)
... 9 more
--------------------------------------------------------------------------------
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571743#action_12571743 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Mmm, I see now that I already reported this issue above. Nevermind twice does not harm ;o)
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588350#action_12588350 ]
Scott Gray commented on OFBIZ-1663:
-----------------------------------
Jacques, I think the error that you were seeing about split payments is a trunk feature that doesn't exist in 4.0
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572386#action_12572386 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Now I used the 1st item (upper left) , and moreover it works when I use 1st cash + credit card. I have not time to investigate now, will do later...
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570693#action_12570693 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Yes I agree,
This is weird, we should not take into account any amount given when processing with a credit card. Note that actually if you give any amount it's ok. BTW it's the same with any payment mean.
In case of multiple payments type sales credit should be only allowed at the last payment method. I tried but I got
2008-02-20 14:57:32,796 (Thread-1742) [ Log4jLoggerWriter.java:67 :INFO ] [POS @ pos-1 TX:11258] - is Aggregated Item(GZ-1001)
2008-02-20 14:57:36,953 (Thread-1744) [ Log4jLoggerWriter.java:67 :INFO ] [POS @ pos-1 TX:11258] - is Aggregated Item(GZ-1001)
2008-02-20 14:57:36,953 (Thread-1744) [ Log4jLoggerWriter.java:67 :INFO ] [POS @ pos-1 TX:11258] - process sale
2008-02-20 14:57:36,968 (Thread-1744) [ ShoppingCart.java:4609:INFO ] Compare [Pm: null / PmType: CASH / Amt: 10.0 / Ref: null!null] to [Pm: 10004 / PmType: CREDIT_CARD / Amt: null / Ref: null!null]
2008-02-20 14:57:36,968 (Thread-1744) [ ShoppingCart.java:4609:INFO ] Compare [Pm: 10004 / PmType: CREDIT_CARD / Amt: 15.989999999999998 / Ref: null!null] to [Pm: 10004 / PmType: CREDIT_CARD / Amt: null
/ Ref: null!null]
2008-02-20 14:57:36,968 (Thread-1744) [ ShoppingCart.java:1454:INFO ] Returned existing PaymentInfo - Pm: 10004 / PmType: CREDIT_CARD / Amt: 15.989999999999998 / Ref: null!null
2008-02-20 14:57:36,984 (Thread-1744) [ PosButton.java:125:ERROR]
---- exception report ----------------------------------------------------------
Button invocation exception - ALT.payFinish
Exception: org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
Message: null
---- stack trace ---------------------------------------------------------------
org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:216)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
java.lang.reflect.InvocationTargetException
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
Caused by: org.ofbiz.base.util.GeneralRuntimeException: Split Payment Preference per Ship Group does not yet support multiple Payment Methods
org.ofbiz.order.shoppingcart.ShoppingCart$CartPaymentInfo.makeOrderPaymentInfos(ShoppingCart.java:4527)
org.ofbiz.order.shoppingcart.ShoppingCart.makeAllOrderPaymentInfos(ShoppingCart.java:3588)
org.ofbiz.order.shoppingcart.ShoppingCart.makeCartMap(ShoppingCart.java:3825)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:572)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:545)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:763)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:306)
... 9 more
--------------------------------------------------------------------------------
I then tried with credit card 1st and cash last, then cash + check and got the same error. Not sure yet if it's a configuration error or something else. And I have no time to investigate further for now. I will see mater and if necessary will open a new Jira issue for this.
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1663) POS: All payment types allow change
to be made
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1663.
----------------------------------
Resolution: Fixed
Chris,
So thanks to Scott I think it's clear now and I close it definitively. Please open a *new* issue if you think it's needed
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.