[couchdb] branch default-repl-session-support created (now 702726b)

[wo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wohali pushed a change to branch default-repl-session-support
in repository https://gitbox.apache.org/repos/asf/couchdb.git.


      at 702726b  Enable replication client _session auth by default

This branch includes the following new commits:

     new 702726b  Enable replication client _session auth by default

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[couchdb] 01/01: Enable replication client _session auth by default

[wo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wohali pushed a commit to branch default-repl-session-support
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 702726bc35eba8024b6d6e22190c7f66dc3899f4
Author: Joan Touzet <jo...@atypical.net>
AuthorDate: Mon Jul 23 19:49:00 2018 -0400

    Enable replication client _session auth by default
    
    Relates to #1153 and #1176
---
 rel/overlay/etc/default.ini                        | 9 ++++-----
 src/couch_replicator/src/couch_replicator_auth.erl | 2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/rel/overlay/etc/default.ini b/rel/overlay/etc/default.ini
index aa9763c..084a16e 100644
--- a/rel/overlay/etc/default.ini
+++ b/rel/overlay/etc/default.ini
@@ -433,13 +433,12 @@ ssl_certificate_max_depth = 3
 ; There are currently two plugins available:
 ;   couch_replicator_auth_session - use _session cookie authentication
 ;   couch_replicator_auth_noop - use basic authentication (previous default)
-; Currently previous default behavior is still the default. To start using
-; session auth, use this as the list of plugins:
-; `couch_replicator_auth_session,couch_replicator_auth_noop`.
-; In a future release the session plugin might be used by default.
+; Currently, the new _session cookie authentication is tried first, before
+; falling back to the old basic authenticaion default:
+;auth_plugins = couch_replicator_auth_session,couch_replicator_auth_noop
+; To restore the old behaviour, use the following value:
 ;auth_plugins = couch_replicator_auth_noop
 
-
 [compaction_daemon]
 ; The delay, in seconds, between each check for which database and view indexes
 ; need to be compacted.
diff --git a/src/couch_replicator/src/couch_replicator_auth.erl b/src/couch_replicator/src/couch_replicator_auth.erl
index 60273fc..7f51cdd 100644
--- a/src/couch_replicator/src/couch_replicator_auth.erl
+++ b/src/couch_replicator/src/couch_replicator_auth.erl
@@ -28,7 +28,7 @@
 -type code() :: non_neg_integer().
 
 
--define(DEFAULT_PLUGINS, "couch_replicator_auth_noop").
+-define(DEFAULT_PLUGINS, "couch_replicator_auth_session,couch_replicator_auth_noop").
 
 
 % Behavior API