You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/02/16 18:34:41 UTC
Review Request 65689: Fixed the task update issue on framework due to
docker daemon hangs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65689/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-8573
https://issues.apache.org/jira/browse/MESOS-8573
Repository: mesos
Description
-------
Fixed the task update issue on framework due to docker daemon hangs.
Diffs
-----
src/slave/slave.cpp df8b33d717d30f550ad90e12c1a6db11fb25b753
Diff: https://reviews.apache.org/r/65689/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 65689: Fixed the task update issue on framework
due to docker daemon hangs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65689/#review197686
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65689']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65689
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65689/logs/mesos-tests-stdout.log):
```
[ RUN ] ExecutorAuthorizationTest.RunTaskGroup
[ OK ] ExecutorAuthorizationTest.RunTaskGroup (2679 ms)
[ RUN ] ExecutorAuthorizationTest.FailedSubscribe
[ OK ] ExecutorAuthorizationTest.FailedSubscribe (265 ms)
[ RUN ] ExecutorAuthorizationTest.FailedApiCalls
[ OK ] ExecutorAuthorizationTest.FailedApiCalls (387 ms)
[----------] 3 tests from ExecutorAuthorizationTest (3391 ms total)
[----------] 4 tests from SlaveCompatibilityTest
[ RUN ] SlaveCompatibilityTest.Equal
[ OK ] SlaveCompatibilityTest.Equal (4 ms)
[ RUN ] SlaveCompatibilityTest.Additive
[ OK ] SlaveCompatibilityTest.Additive (8 ms)
[ RUN ] SlaveCompatibilityTest.AdditiveWithReservations
[ OK ] SlaveCompatibilityTest.AdditiveWithReservations (4 ms)
[ RUN ] SlaveCompatibilityTest.Disks
[ OK ] SlaveCompatibilityTest.Disks (3 ms)
[----------] 4 tests from SlaveCompatibilityTest (23 ms total)
[----------] 75 tests from SlaveTest
[ RUN ] SlaveTest.Shutdown
[ OK ] SlaveTest.Shutdown (232 ms)
[ RUN ] SlaveTest.DuplicateTerminalUpdateBeforeAck
[ OK ] SlaveTest.DuplicateTerminalUpdateBeforeAck (294 ms)
[ RUN ] SlaveTest.ShutdownUnregisteredExecutor
D:\DCOS\mesos\mesos\src\tests\slave_tests.cpp(439): error: Failed to wait 15secs for status
D:\DCOS\mesos\mesos\src\tests\slave_tests.cpp(425): error: Actual function call count doesn't match EXPECT_CALL(sched, statusUpdate(&driver, _))...
Expected: to be called once
Actual: never called - unsatisfied and active
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65689/logs/mesos-tests-stderr.log):
```
I0216 19:43:08.213665 1888 master.cpp:1422] Framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 (default) at scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339 disconnected
I0216 19:43:08.214664 1888 master.cpp:3240] Deactivating framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 (default) at scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.214664 1888 master.cpp:3217] Disconnecting framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 (default) at scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.214664 10268 hierarchical.cpp:405] Deactivated framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000
I0216 19:43:08.214664 1888 master.cpp:1437] Giving framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 (default) at scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339 0ns to failover
I0216 19:43:08.216671 4916 master.cpp:8668] Framework failover timeout, removing framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 (default) at scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.216671 4916 master.cpp:9545] Removing framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 (default) at scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.216671 4916 master.cpp:10249] Updating the state of task 1 of framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0216 19:43:08.218672 4916 master.cpp:10348] Removing task 1 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-0000 on agent @ 00007FF64DAE0B1A )<process::ProcessBase * __ptr64
@ 00007FF64DB0AFDC std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF64DB8E5CC std::invoke<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF64DAE8BF1 )<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> >,process::ProcessBase * __ptr64
@ 00007FF64DC22926 process::ProcessBase * __ptr64)>::CallableFn<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> > >::operator(
@ 00007FF64F662F3D process::ProcessBase * __ptr64)>::operator(
@ 00007FF64F53C209 process::ProcessBase::consume
@ 00007FF64F6B67FA process::DispatchEvent::consume
@ 00007FF64B88C8F7 process::ProcessBase::serve
@ 00007FF64F54A120 process::ProcessManager::resume
@ 00007FF64F653691 ??
@ 00007FF64F592380 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF64F5E7FD0 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF64F5A10FC std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF64F69EABA std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF64F68B618 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF64F67361D std::_Pad::_Call_func
@ 00007FF6508437E8 invoke_thread_procedure
@ 00007FF650843291 __cdecl*)(void * __ptr64)
@ 00007FF8E3F91FE4 BaseThreadInitThunk
@ 00007FF8E6A4EFB1 RtlUserThreadStart
```
- Mesos Reviewbot Windows
On Feb. 16, 2018, 6:34 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65689/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2018, 6:34 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-8573
> https://issues.apache.org/jira/browse/MESOS-8573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the task update issue on framework due to docker daemon hangs.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp df8b33d717d30f550ad90e12c1a6db11fb25b753
>
>
> Diff: https://reviews.apache.org/r/65689/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 65689: Fixed the task update issue on framework
due to docker daemon hangs.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65689/
-----------------------------------------------------------
(Updated Feb. 19, 2018, 11:20 p.m.)
Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Vinod Kone.
Changes
-------
Added comments.
Bugs: MESOS-8573
https://issues.apache.org/jira/browse/MESOS-8573
Repository: mesos
Description
-------
Fixed the task update issue on framework due to docker daemon hangs.
Diffs (updated)
-----
src/slave/slave.cpp df8b33d717d30f550ad90e12c1a6db11fb25b753
Diff: https://reviews.apache.org/r/65689/diff/2/
Changes: https://reviews.apache.org/r/65689/diff/1-2/
Testing
-------
make check
Thanks,
Gilbert Song