You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rave.apache.org by marijan milicevic <m....@onehippo.com> on 2012/03/06 10:15:17 UTC

Re: Review Request: implemented flashscope

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4019/
-----------------------------------------------------------

(Updated 2012-03-06 09:15:17.122124)


Review request for rave.


Changes
-------

(ping)


Summary (updated)
-------

messages shown after account added, password changed etc.


Diffs
-----

  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ChangePasswordController.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ChangePasswordControllerTest.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext.xml 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/login.jsp PRE-CREATION 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml 1292935 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/login.jsp 1292935 

Diff: https://reviews.apache.org/r/4019/diff


Testing
-------


Thanks,

marijan

Re: Review Request: implemented flashscope

Posted by marijan milicevic <m....@onehippo.com>.

Hi Marlon,

On 03/12/2012 08:10 PM, Marlon Pierce wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Marijan, what Jira issue number is this?

patch is already applied by Jasha, issue:

https://issues.apache.org/jira/browse/RAVE-411


cheers
marijan


>
> Thanks--
>
>
> Marlon
>
>
> On 3/6/12 4:15 AM, marijan milicevic wrote:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/4019/
>> -----------------------------------------------------------
>>
>> (Updated 2012-03-06 09:15:17.122124)
>>
>>
>> Review request for rave.
>>
>>
>> Changes
>> -------
>>
>> (ping)
>>
>>
>> Summary (updated)
>> -------
>>
>> messages shown after account added, password changed etc.
>>
>>
>> Diffs
>> -----
>>
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ChangePasswordController.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ChangePasswordControllerTest.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext.xml 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/login.jsp PRE-CREATION
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml 1292935
>>    https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/login.jsp 1292935
>>
>> Diff: https://reviews.apache.org/r/4019/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> marijan
>>
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJPXko7AAoJEEfVXEODPFIDOpUIAKHNkKlAetVuZDv1cQqZo1QU
> UwfbYqojDx67mo32J41e8asCmvl+0Yzo2U1snsMEJ49ZGV6mj3FHWOShY++TK7aw
> gPbPUcY3x9Btk6jQ1dhwntekJxlBIcTt9I8zNKliqYcKOdtToktPllJbcTpcX22j
> cO0k+COg9DNkIFyj+wtGYlPwf/iKYrrvQ0zQCZdNNG8z5Q2BQixaa9SDFdEuQW/D
> 9Y8h0gA/hZbI8Nkd4umXK5O8/H4oEcwSpnD6OAVAsfarKPs+xL7F0JpYPr8KjNeW
> JM6XB/CUDwVRLi4VRh0Pwa8JtGNBy0uiUIQpUUIZK2hvf13xGTNDkVtzxwspctc=
> =lRNm
> -----END PGP SIGNATURE-----

Re: Review Request: implemented flashscope

Posted by Marlon Pierce <ma...@iu.edu>.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Marijan, what Jira issue number is this?


Thanks--


Marlon


On 3/6/12 4:15 AM, marijan milicevic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4019/
> -----------------------------------------------------------
> 
> (Updated 2012-03-06 09:15:17.122124)
> 
> 
> Review request for rave.
> 
> 
> Changes
> -------
> 
> (ping)
> 
> 
> Summary (updated)
> -------
> 
> messages shown after account added, password changed etc.
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ChangePasswordController.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ChangePasswordControllerTest.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext-security.xml 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext.xml 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/login.jsp PRE-CREATION 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml 1292935 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/login.jsp 1292935 
> 
> Diff: https://reviews.apache.org/r/4019/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> marijan
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPXko7AAoJEEfVXEODPFIDOpUIAKHNkKlAetVuZDv1cQqZo1QU
UwfbYqojDx67mo32J41e8asCmvl+0Yzo2U1snsMEJ49ZGV6mj3FHWOShY++TK7aw
gPbPUcY3x9Btk6jQ1dhwntekJxlBIcTt9I8zNKliqYcKOdtToktPllJbcTpcX22j
cO0k+COg9DNkIFyj+wtGYlPwf/iKYrrvQ0zQCZdNNG8z5Q2BQixaa9SDFdEuQW/D
9Y8h0gA/hZbI8Nkd4umXK5O8/H4oEcwSpnD6OAVAsfarKPs+xL7F0JpYPr8KjNeW
JM6XB/CUDwVRLi4VRh0Pwa8JtGNBy0uiUIQpUUIZK2hvf13xGTNDkVtzxwspctc=
=lRNm
-----END PGP SIGNATURE-----