[GitHub] [helix] narendly opened a new pull request #432: TASK: Fix incorrect counting of numAttempts for tasks

[GitBox <gi...@apache.org>]

narendly opened a new pull request #432: TASK: Fix incorrect counting of numAttempts for tasks
URL: https://github.com/apache/helix/pull/432
 
 
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR title:
   
   This PR fixes #424 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   It was discovered that sometimes the tasks' NUM_ATTEMPTS field in JobContext was getting incremented even without the tasks being retried. This was because the numAttempts field was getting incremented in other (incorrect) places than at scheduling time. The logic for incrementing the number of attempts has been moved to the schedule logic in this diff.
   Changelist:
   1. Modify tests so that they test for numAttempts more tightly
   2. Fix the incrementation logic
   3. Add a new integration test: TestTaskNumAttempts
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   TestIndependentTaskRebalancer
   
   TestTaskConditionalRetry
   
   TestTaskRebalancer
   
   TestTaskRebalancerRetryLimit
   
   TestUnregisteredCommand
   
   **TestTaskNumAttempts** (new addition)
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Copy & paste the result of "mvn test")
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org