You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:21:13 UTC
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #532: reuse datafusion physical planner in ballista building from protobuf
Jimexist commented on a change in pull request #532:
URL: https://github.com/apache/arrow-datafusion/pull/532#discussion_r649843237
##########
File path: datafusion/src/physical_plan/windows.rs
##########
@@ -61,24 +63,27 @@ pub struct WindowAggExec {
/// Create a physical expression for window function
pub fn create_window_expr(
fun: &WindowFunction,
+ name: String,
args: &[Arc<dyn PhysicalExpr>],
+ _partition_by: &[Arc<dyn PhysicalExpr>],
+ _order_by: &[PhysicalSortExpr],
+ _window_frame: WindowFrame,
Review comment:
it'll be further developed in https://github.com/apache/arrow-datafusion/pull/520
##########
File path: datafusion/src/physical_plan/windows.rs
##########
@@ -61,24 +63,27 @@ pub struct WindowAggExec {
/// Create a physical expression for window function
pub fn create_window_expr(
fun: &WindowFunction,
+ name: String,
args: &[Arc<dyn PhysicalExpr>],
+ _partition_by: &[Arc<dyn PhysicalExpr>],
+ _order_by: &[PhysicalSortExpr],
+ _window_frame: WindowFrame,
Review comment:
but that's a good point let me add guard here.
##########
File path: datafusion/src/physical_plan/windows.rs
##########
@@ -61,24 +63,27 @@ pub struct WindowAggExec {
/// Create a physical expression for window function
pub fn create_window_expr(
fun: &WindowFunction,
+ name: String,
args: &[Arc<dyn PhysicalExpr>],
+ _partition_by: &[Arc<dyn PhysicalExpr>],
+ _order_by: &[PhysicalSortExpr],
+ _window_frame: WindowFrame,
Review comment:
this is fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org