You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/10/23 06:47:19 UTC
[GitHub] zeppelin pull request #2628: [ZEPPELIN-2999] Cannot create shell interpreter...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2628
[ZEPPELIN-2999] Cannot create shell interpreter without timeout property
### What is this PR for?
A user can not run any shell interpreter if "shell.command.timeout.millisecs" is not present in interpreter setting.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [https://issues.apache.org/jira/browse/ZEPPELIN-2999](https://issues.apache.org/jira/browse/ZEPPELIN-2999)
### How should this be tested?
* Remove "shell.command.timeout.millisecs" from sh interpreter settings and then try to run any sh paragraph, it should run without any error.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2628.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2628
----
commit e2a62f63d2a14ac0c13ca9774dbede3946736f8b
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-10-23T06:43:24Z
ZEPPELIN-2999: Cannot create shell interpreter without timeout property
----
---
[GitHub] zeppelin issue #2628: [ZEPPELIN-2999] Cannot create shell interpreter withou...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2628
Thanks for the review, will merge this if no more discussion.
---
[GitHub] zeppelin issue #2628: [ZEPPELIN-2999] Cannot create shell interpreter withou...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2628
@toughrogrammer What I think you are looking for is "INFINITE_TIMEOUT = -1L", in which case I would recommend instead of removing this "shell.command.timeout.millisecs" parameter pass "-1" in the Zeppelin interpreter setting. Any thoughts?
---
[GitHub] zeppelin issue #2628: [ZEPPELIN-2999] Cannot create shell interpreter withou...
Posted by toughrogrammer <gi...@git.apache.org>.
Github user toughrogrammer commented on the issue:
https://github.com/apache/zeppelin/pull/2628
I'm reporter of ZEPPELIN-2999. IMO it's invalid solution. With this code, it cannot run without timeout. What I intend with no timeout option is I will approve waiting command execution forever.
---
[GitHub] zeppelin pull request #2628: [ZEPPELIN-2999] Cannot create shell interpreter...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2628
[ZEPPELIN-2999] Cannot create shell interpreter without timeout property
### What is this PR for?
A user can not run any shell interpreter if "shell.command.timeout.millisecs" is not present in interpreter setting.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [https://issues.apache.org/jira/browse/ZEPPELIN-2999](https://issues.apache.org/jira/browse/ZEPPELIN-2999)
### How should this be tested?
* Remove "shell.command.timeout.millisecs" from sh interpreter settings and then try to run any sh paragraph, it should run without any error.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2628.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2628
----
commit e2a62f63d2a14ac0c13ca9774dbede3946736f8b
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-10-23T06:43:24Z
ZEPPELIN-2999: Cannot create shell interpreter without timeout property
commit 4406157d2205f95e74815406f6f9e3ec20127150
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-10-23T07:31:19Z
use "getProperty(String key, String defaultValue)" instead of "getProperty(String key)"
----
---
[GitHub] zeppelin pull request #2628: [ZEPPELIN-2999] Cannot create shell interpreter...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2628
---
[GitHub] zeppelin pull request #2628: [ZEPPELIN-2999] Cannot create shell interpreter...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2628
---
[GitHub] zeppelin issue #2628: [ZEPPELIN-2999] Cannot create shell interpreter withou...
Posted by toughrogrammer <gi...@git.apache.org>.
Github user toughrogrammer commented on the issue:
https://github.com/apache/zeppelin/pull/2628
@prabhjyotsingh Exactly.
---