You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/03/01 00:11:36 UTC

[Impala-CR](cdh5-trunk) IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax

Thomas Tauber-Marshall has uploaded a new patch set (#3).

Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax
......................................................................

IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax

Added the ability for the "GRANT/REVOKE ALL ON SERVER TO ROLE <role>"
statement to optionally take a server name parameter as:
"GRANT/REVOKE ALL ON SERVER <server> TO ROLE <role>" since Hive
allows this.

We accept anything for the value of <server> and just pass it
along to Sentry, as this is consistent with Hive's behavior.

Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/AuthorizationPolicy.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeAuthStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
5 files changed, 152 insertions(+), 91 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/96/2296/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>