You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Adam Winer <aw...@gmail.com> on 2007/08/03 00:36:59 UTC

Re: TRINIDAD : Trinidad - 85 : Adam's Comments - question

We should have an agent capability flag for this.
See the files in trinidad-impl/src/main/resources/META-INF/agents
as well as org.apache.myfaces.trinidadinternal.agent.TrinidadAgent.

The problem with "isPDA()" is that we've lost all context
for what feature is really relevant, and no decent way to indicate
that some PDA might in fact support the feature, either now
or in the future.

-- Adam


On 8/2/07, Piyush Hari <pi...@oracle.com> wrote:
> Adam,
>
> You commented the following on my patch for TRINIDAD - 85
> https://issues.apache.org/jira/browse/TRINIDAD-85 :
>
> /"I'm not fond of the isPDA() check. Please add an agent flag, defaulting
> to true, and set it to false for the relevant platforms. I also see a lot
> of non-two-space whitespace here."
>
> /Can you elaborate a bit more on what you are recommending ?  What do
> you mean by an agent flag ?
>
> Thanks,
> -Piyush
>

Re: TRINIDAD : Trinidad - 85 : Adam's Comments - question

Posted by Piyush Hari <pi...@oracle.com>.
Hi Adam,

I have uploaded the newest patch in accordance with the formatting 
standards and also removed isPDA check since I made it a capability. I 
will appreciate if you can take a look and close /resolve the issue.
https://issues.apache.org/jira/browse/TRINIDAD-85

patch_Aug03_07_16_01_commandButtonWithIconPDA.patch

Thanks,
Piyush

Adam Winer wrote:
> The naming pattern we've used would look more like:
> -adfinternal-onclickOnImgInput
>
> -- Adam
>
>
> On 8/3/07, Piyush Hari <pi...@oracle.com> wrote:
>   
>> Am I allowed to name for this capability ? Basically, my capability is
>> testing if "onclick" is supported on "input" element of type "img"  ?
>>
>> How about : something like this :
>>
>> <capability name="-adfinternal-onclick-input-img" value="false"/>
>>
>> Are you ok with this name ?
>>
>> -Piyush
>>
>>
>> Adam Winer wrote:
>>     
>>> We should have an agent capability flag for this.
>>> See the files in trinidad-impl/src/main/resources/META-INF/agents
>>> as well as org.apache.myfaces.trinidadinternal.agent.TrinidadAgent.
>>>
>>> The problem with "isPDA()" is that we've lost all context
>>> for what feature is really relevant, and no decent way to indicate
>>> that some PDA might in fact support the feature, either now
>>> or in the future.
>>>
>>> -- Adam
>>>
>>>
>>> On 8/2/07, Piyush Hari <pi...@oracle.com> wrote:
>>>
>>>       
>>>> Adam,
>>>>
>>>> You commented the following on my patch for TRINIDAD - 85
>>>> https://issues.apache.org/jira/browse/TRINIDAD-85 :
>>>>
>>>> /"I'm not fond of the isPDA() check. Please add an agent flag, defaulting
>>>> to true, and set it to false for the relevant platforms. I also see a lot
>>>> of non-two-space whitespace here."
>>>>
>>>> /Can you elaborate a bit more on what you are recommending ?  What do
>>>> you mean by an agent flag ?
>>>>
>>>> Thanks,
>>>> -Piyush
>>>>
>>>>
>>>>         
>>

Re: TRINIDAD : Trinidad - 85 : Adam's Comments - question

Posted by Adam Winer <aw...@gmail.com>.
The naming pattern we've used would look more like:
-adfinternal-onclickOnImgInput

-- Adam


On 8/3/07, Piyush Hari <pi...@oracle.com> wrote:
> Am I allowed to name for this capability ? Basically, my capability is
> testing if "onclick" is supported on "input" element of type "img"  ?
>
> How about : something like this :
>
> <capability name="-adfinternal-onclick-input-img" value="false"/>
>
> Are you ok with this name ?
>
> -Piyush
>
>
> Adam Winer wrote:
> > We should have an agent capability flag for this.
> > See the files in trinidad-impl/src/main/resources/META-INF/agents
> > as well as org.apache.myfaces.trinidadinternal.agent.TrinidadAgent.
> >
> > The problem with "isPDA()" is that we've lost all context
> > for what feature is really relevant, and no decent way to indicate
> > that some PDA might in fact support the feature, either now
> > or in the future.
> >
> > -- Adam
> >
> >
> > On 8/2/07, Piyush Hari <pi...@oracle.com> wrote:
> >
> >> Adam,
> >>
> >> You commented the following on my patch for TRINIDAD - 85
> >> https://issues.apache.org/jira/browse/TRINIDAD-85 :
> >>
> >> /"I'm not fond of the isPDA() check. Please add an agent flag, defaulting
> >> to true, and set it to false for the relevant platforms. I also see a lot
> >> of non-two-space whitespace here."
> >>
> >> /Can you elaborate a bit more on what you are recommending ?  What do
> >> you mean by an agent flag ?
> >>
> >> Thanks,
> >> -Piyush
> >>
> >>
>
>

Re: TRINIDAD : Trinidad - 85 : Adam's Comments - question

Posted by Piyush Hari <pi...@oracle.com>.
Am I allowed to name for this capability ? Basically, my capability is 
testing if "onclick" is supported on "input" element of type "img"  ?

How about : something like this :

<capability name="-adfinternal-onclick-input-img" value="false"/> 

Are you ok with this name ?

-Piyush


Adam Winer wrote:
> We should have an agent capability flag for this.
> See the files in trinidad-impl/src/main/resources/META-INF/agents
> as well as org.apache.myfaces.trinidadinternal.agent.TrinidadAgent.
>
> The problem with "isPDA()" is that we've lost all context
> for what feature is really relevant, and no decent way to indicate
> that some PDA might in fact support the feature, either now
> or in the future.
>
> -- Adam
>
>
> On 8/2/07, Piyush Hari <pi...@oracle.com> wrote:
>   
>> Adam,
>>
>> You commented the following on my patch for TRINIDAD - 85
>> https://issues.apache.org/jira/browse/TRINIDAD-85 :
>>
>> /"I'm not fond of the isPDA() check. Please add an agent flag, defaulting
>> to true, and set it to false for the relevant platforms. I also see a lot
>> of non-two-space whitespace here."
>>
>> /Can you elaborate a bit more on what you are recommending ?  What do
>> you mean by an agent flag ?
>>
>> Thanks,
>> -Piyush
>>
>>