[GitHub] [beam] TheNeuralBit commented on a change in pull request #13487: [BEAM-11394] Make job server Java launcher configurable via pipeline …

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #13487:
URL: https://github.com/apache/beam/pull/13487#discussion_r537858120



##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -1176,6 +1176,12 @@ def _add_argparse_args(cls, parser):
         default=0,
         help='Port to use for artifact staging. 0 to use a '
         'dynamic port.')
+    parser.add_argument(
+        '--java_launcher',
+        default='java',
+        help='The Java Application Launcher executable file to use for '
+        'starting a Java job server. If unset, `java` from the '
+        'environment\'s $PATH is used.')

Review comment:
       you noted the expansion service isn't affected by this PR - _should_ this arg affect the expansion service launcher as well, or should that be configured separately?
   
   If the former why not go ahead and wire it up
   If the latter this should be `java_job_server_launcher` (or something) to disambiguate from a possible future param for expansion services.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org