You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/02/20 12:03:00 UTC

[jira] [Commented] (HBASE-23648) Re-use underlying connection registry in RawAsyncHBaseAdmin

    [ https://issues.apache.org/jira/browse/HBASE-23648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040895#comment-17040895 ] 

Hudson commented on HBASE-23648:
--------------------------------

Results for branch master
	[build #1637 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1637/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1637//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1637//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1637//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Re-use underlying connection registry in RawAsyncHBaseAdmin
> -----------------------------------------------------------
>
>                 Key: HBASE-23648
>                 URL: https://issues.apache.org/jira/browse/HBASE-23648
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 3.0.0
>            Reporter: Bharath Vissapragada
>            Assignee: Bharath Vissapragada
>            Priority: Minor
>             Fix For: HBASE-18095
>
>
> Based on the discussion between [~stack] and I in the code review for HBASE-23305, the current usage of ConnectionRegistry is ad-hoc, sometimes multiple times per connection.
> Before Duo's Comment: don't see any obvious reason to not make it a singleton (except for testing). This makes it more readable.
> Edited to: Fix RawAsyncHBaseAdmin's creation of adhoc registry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)