[GitHub] savelandr opened a new issue #6225: node.sh errors if no JAVA_HOME set

[GitBox <gi...@apache.org>]

savelandr opened a new issue #6225: node.sh errors if no JAVA_HOME set
URL: https://github.com/apache/incubator-druid/issues/6225
 
 
   https://github.com/apache/incubator-druid/blob/ceb8f8e6258e1d113d8162a9a8a2fc62810704eb/examples/bin/node.sh#L45
   
   This is running `#!/bin/bash -eu`, so it will exit whenever an unbound variable is encountered.  That's what the `-u` option does.  The test for `"$JAVA_HOME"` will be referencing an unbound variable in the event that `JAVA_HOME` is not set, therefore throwing an error and exiting.  So the test doesn't actually accomplish what it is trying to accomplish. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org