[GitHub] [helix] lei-xia commented on a change in pull request #1227: Implement thread leakage check, fixing major thread leakage test and some flaky test

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #1227:
URL: https://github.com/apache/helix/pull/1227#discussion_r500462866



##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java
##########
@@ -181,6 +181,12 @@ private BestPossAndExtViewZkVerifier(HelixZkClient zkClient, String clusterName,
       this.resources = resources;
     }
 
+    public void close() {

Review comment:
       Can we put this into a separate PR? i.e, add close method to ClusterStateVerifier.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org