You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/05 19:07:53 UTC
[GitHub] [incubator-superset] junlincc opened a new issue #11582: [Dashboard-Filter-Indicator] Chart title is covered by new filter indicator
junlincc opened a new issue #11582:
URL: https://github.com/apache/incubator-superset/issues/11582
we recently implemented new dashboard filter indicator to replace the old "teeth" design, with the purpose of providing better simplicity and improving consistency in dashboard.
Main changes as follow:
- State A No Filters Scope When no filters are scoped on the chart, there is no indicator
- State B Filters Scoped, Not Applied When there are no applied filters, the indicator is just the filter icon
- State C Filter Applied When filters are applied, the indicator shows the number of applied filters
- State D Some Incompatible Filters When there are incompatible filters, the indicator turns yellow and shows applied filters as well as incompatible filters.
<img width="1425" alt="Screen Shot 2020-11-05 at 10 46 12 AM" src="https://user-images.githubusercontent.com/67837651/98283225-2a295d80-1f54-11eb-8947-8634b35a8244.png">
As we moved the indicator inside of the chart area, one minor change we made is we applied fixed height and width on the chart title to avoid title and indicator overlapping and to create better visual alignment.
This minor change has caused some usability problems to users whose charts have long titles. Chart titles can't be entirely shown in this implementation. We are working on the enhancement currently, and I apologize for all the inconvenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11582: [Dashboard-Filter-Indicator] Chart title is covered by new filter indicator
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11582:
URL: https://github.com/apache/incubator-superset/issues/11582#issuecomment-722580315
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.63. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #11582: [Dashboard-Filter-Indicator] Chart title is covered by new filter indicator
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #11582:
URL: https://github.com/apache/incubator-superset/issues/11582#issuecomment-722609253
the chart options dropdown icon should use vertical dot not horizontal dot. please update your design doc to reflect reality.
Can you also show the UI for filter status overlay? width? text align? opaque?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #11582: [Dashboard-Filter-Indicator] Chart title is covered by new filter indicator
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #11582:
URL: https://github.com/apache/incubator-superset/issues/11582#issuecomment-722609253
the chart options dropdown icon should use vertical dot not horizontal dot. please update your design doc to reflect reality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11582: [Dashboard-Filter-Indicator] Chart title is covered by new filter indicator
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11582:
URL: https://github.com/apache/incubator-superset/issues/11582#issuecomment-722582254
@etr2460 @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #11582: [Dashboard-Filter-Indicator] Chart title is covered by new filter indicator
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #11582:
URL: https://github.com/apache/incubator-superset/issues/11582#issuecomment-722609253
the chart options list icon should use vertical dot not horizontal dot. please update your design doc to reflect reality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc closed issue #11582: [Dashboard-Filter-Indicator] Chart title is covered by new filter indicator
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #11582:
URL: https://github.com/apache/incubator-superset/issues/11582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org