You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/07/02 02:41:31 UTC
[kudu-CR] [docs] Add admin docs for backup and restore
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13780
Change subject: [docs] Add admin docs for backup and restore
......................................................................
[docs] Add admin docs for backup and restore
This patch adds the basic documentation for using the
`KuduBackup` and `KuduRestore` Spark jobs.
Additionally it relocates the pysical backup section to
be colocated with the new backup documention.
Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
---
M docs/administration.adoc
1 file changed, 188 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13780/1
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13780
to look at the new patch set (#4).
Change subject: [docs] Add admin docs for backup and restore
......................................................................
[docs] Add admin docs for backup and restore
This patch adds the basic documentation for using the
`KuduBackup` and `KuduRestore` Spark jobs.
Additionally it relocates the pysical backup section to
be colocated with the new backup documention.
Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
---
M docs/administration.adoc
1 file changed, 189 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13780/4
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 4:
(6 comments)
Probably worth adding a rendered version, saw a rendering issue here https://github.com/andrwng/kudu/blob/bdr-docs/docs/administration.adoc#backup
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@327
PS4, Line 327: backups linked
backups are linked
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@336
PS4, Line 336: below
nit: could link using <<>>
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@336
PS4, Line 336: rootPath
nit: backticks
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@362
PS4, Line 362:
: Commands:
: * `list`: Lists the backups in the rootPath.
: * `clean`: Cleans up old backup data in the rootPath.
I think you need a newline after "Commands:"; this doesn't render as a list.
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@431
PS4, Line 431: spark
nit: uppercase
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@432
PS4, Line 432: 50 columns.
Not actionable I don't think, but I'm surprised this isn't some bytes-per-row or bytes-per-batch value or something.
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 00:26:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@327
PS4, Line 327: backups are li
> backups are linked
Done
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@336
PS4, Line 336: <<bac
> nit: could link using <<>>
Done
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@336
PS4, Line 336: re used
> nit: backticks
Done
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@362
PS4, Line 362:
: Commands:
:
: * `list`: Lists the backups in the rootPath.
> I think you need a newline after "Commands:"; this doesn't render as a list
Done
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@431
PS4, Line 431:
> nit: uppercase
Done
http://gerrit.cloudera.org:8080/#/c/13780/4/docs/administration.adoc@432
PS4, Line 432: de and your
> Not actionable I don't think, but I'm surprised this isn't some bytes-per-r
More feedback/experience with the backups might improve this.
http://gerrit.cloudera.org:8080/#/c/13780/5/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/5/docs/administration.adoc@304
PS5, Line 304: ** See below for the directory structure used in the rootPath.
> Update this line too?
Done
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 00:54:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 01:03:53 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13780
to look at the new patch set (#2).
Change subject: [docs] Add admin docs for backup and restore
......................................................................
[docs] Add admin docs for backup and restore
This patch adds the basic documentation for using the
`KuduBackup` and `KuduRestore` Spark jobs.
Additionally it relocates the pysical backup section to
be colocated with the new backup documention.
Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
---
M docs/administration.adoc
1 file changed, 187 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13780/2
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 01:06:07 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@398
PS1, Line 398: Writte
> True, I was worried that was a bit too much detail for admin docs and poten
yeah, maybe consider removing it then? I'm vaguely familiar with backup and restore so I kind of get what this means, but I'm not sure a typical operator might. Up to you.
http://gerrit.cloudera.org:8080/#/c/13780/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/2/docs/administration.adoc@423
PS2, Line 423: eneral
general
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 22:21:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13780
to look at the new patch set (#3).
Change subject: [docs] Add admin docs for backup and restore
......................................................................
[docs] Add admin docs for backup and restore
This patch adds the basic documentation for using the
`KuduBackup` and `KuduRestore` Spark jobs.
Additionally it relocates the pysical backup section to
be colocated with the new backup documention.
Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
---
M docs/administration.adoc
1 file changed, 189 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13780/3
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@303
PS1, Line 303: Spark compatible
> nit: Spark-compatible, here and below
Done
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@310
PS1, Line 310: KuduBackup
> nit: backticks
Done
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@323
PS1, Line 323: les th
> nit: add a comma
Done
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@342
PS1, Line 342: Job
> nit: lowercase?
Done
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@344
PS1, Line 344: KuduRestore
> nit: backticks
Done
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@371
PS1, Line 371: hadoop classpath
> Is this an actual command? If not, maybe this should be en environment vari
This is an actual command.
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@396
PS1, Line 396: Currently the `toMs` time for the job.
> Not sure I understand this
Maybe I will just remove it. It's extra detail now worth explaining.
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@398
PS1, Line 398: linking
> Might be worth adding a bit of description somewhere for what linking means
True, I was worried that was a bit too much detail for admin docs and potentially an implementation detail that could change over time. Maybe a blog post or other docs location could be updated.
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@424
PS1, Line 424: General
> lowercase
Done
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@426
PS1, Line 426: Sparks
> Spark's
Done
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 22:07:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Andrew Wong, Priyanka Chheda, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13780
to look at the new patch set (#5).
Change subject: [docs] Add admin docs for backup and restore
......................................................................
[docs] Add admin docs for backup and restore
This patch adds the basic documentation for using the
`KuduBackup` and `KuduRestore` Spark jobs.
Additionally it relocates the pysical backup section to
be colocated with the new backup documention.
Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
---
M docs/administration.adoc
1 file changed, 191 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13780/5
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
[docs] Add admin docs for backup and restore
This patch adds the basic documentation for using the
`KuduBackup` and `KuduRestore` Spark jobs.
Additionally it relocates the pysical backup section to
be colocated with the new backup documention.
Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Reviewed-on: http://gerrit.cloudera.org:8080/13780
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M docs/administration.adoc
1 file changed, 191 insertions(+), 29 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@303
PS1, Line 303: Spark compatible
nit: Spark-compatible, here and below
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@310
PS1, Line 310: KuduBackup
nit: backticks
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@323
PS1, Line 323: les th
nit: add a comma
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@342
PS1, Line 342: Job
nit: lowercase?
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@344
PS1, Line 344: KuduRestore
nit: backticks
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@371
PS1, Line 371: hadoop classpath
Is this an actual command? If not, maybe this should be en environment variable? Or surrounded by <>s?
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@396
PS1, Line 396: Currently the `toMs` time for the job.
Not sure I understand this
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@398
PS1, Line 398: linking
Might be worth adding a bit of description somewhere for what linking means in the context of backup and restore?
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@424
PS1, Line 424: General
lowercase
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@426
PS1, Line 426: Sparks
Spark's
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 21:53:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Andrew Wong, Priyanka Chheda, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13780
to look at the new patch set (#6).
Change subject: [docs] Add admin docs for backup and restore
......................................................................
[docs] Add admin docs for backup and restore
This patch adds the basic documentation for using the
`KuduBackup` and `KuduRestore` Spark jobs.
Additionally it relocates the pysical backup section to
be colocated with the new backup documention.
Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
---
M docs/administration.adoc
1 file changed, 191 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13780/6
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/1/docs/administration.adoc@398
PS1, Line 398: Writte
> yeah, maybe consider removing it then? I'm vaguely familiar with backup and
I added a sentence to the restore section to clarify this a bit.
http://gerrit.cloudera.org:8080/#/c/13780/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/2/docs/administration.adoc@423
PS2, Line 423: eneral
> general
Done
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 22:29:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add admin docs for backup and restore
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13780 )
Change subject: [docs] Add admin docs for backup and restore
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
One last thing I think.
http://gerrit.cloudera.org:8080/#/c/13780/5/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13780/5/docs/administration.adoc@304
PS5, Line 304: ** See below for the directory structure used in the rootPath.
Update this line too?
--
To view, visit http://gerrit.cloudera.org:8080/13780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f92d3f10fd5d970099e933d8de2d7662e03398
Gerrit-Change-Number: 13780
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 00:40:57 +0000
Gerrit-HasComments: Yes