[GitHub] [kafka] Cerchie commented on a diff in pull request #13161: Kafka 14128

["Cerchie (via GitHub)" <gi...@apache.org>]

Cerchie commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1088951633


##########
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##########
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable cause) {
      * Waits if necessary for this future to complete, and then returns its result.
      */
     @Override
-    public T get() throws InterruptedException, ExecutionException {
+    public abstract T get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException, TimeoutException {

Review Comment:
   That makes sense! I think this change might be in here by accident -- I thought I had done that. Thanks for pointing that out. I'll remove it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org