You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/29 13:37:53 UTC

[GitHub] [spark] srowen commented on a diff in pull request #37694: [SPARK-40246][BUILD] Make log4j-slf4j-impl always be a compile dependency

srowen commented on code in PR #37694:
URL: https://github.com/apache/spark/pull/37694#discussion_r957348587


##########
pom.xml:
##########
@@ -750,7 +750,6 @@
         <groupId>org.apache.logging.log4j</groupId>
         <artifactId>log4j-slf4j-impl</artifactId>
         <version>${log4j.version}</version>
-        <scope>${hadoop.deps.scope}</scope>

Review Comment:
   Well, none of Spark works without Hadoop libs anyway, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org