You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/30 23:37:13 UTC

[GitHub] [airflow] mik-laj commented on pull request #15100: Add support for arbitrary json in conn uri format

mik-laj commented on pull request #15100:
URL: https://github.com/apache/airflow/pull/15100#issuecomment-810646525


   I like this solution with the use of a special key. I don't understand the role of base64 here. Is it necessary? It seems to me that the pure value will be easier to use, e.g. you will be able to check the connection configuration by looking at the environment variables. 
   
   As for supporting other types, I'm not sure we want to support it. We expect the extra field to be a Web UI dictionary. The use of primitive types also causes a problem with extending a given connection ie.  it is not future-proff.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org