You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/03/28 19:12:23 UTC

Review Request 19791: gmond.master.conf files are generated by Ganglia Server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19791/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-5245
    https://issues.apache.org/jira/browse/AMBARI-5245


Repository: ambari


Description
-------

Fixed jira, also refactored RMFTestCase.py a bit 


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 8c63b23 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py b27bf61 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py 65d5e66 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py f257f83 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py a1c1b41 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py d7f6e41 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 85fceca 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py 9e7630c 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 8a21873 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 82cedd8 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c835c94 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json  
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 8983882 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py b5adcbd 

Diff: https://reviews.apache.org/r/19791/diff/


Testing
-------

Tried installing 1.3.2 and 2.1 stacks, also tried 2-node cluster setup.

----------------------------------------------------------------------
Ran 190 tests in 0.460s

OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko

Re: Review Request 19791: gmond.master.conf files are generated by Ganglia Server

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On March 28, 2014, 6:23 p.m., Andrew Onischuk wrote:
> > ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py, line 237
> > <https://reviews.apache.org/r/19791/diff/1/?file=539865#file539865line237>
> >
> >     don't copy the same content please in scripts, they get too big then and unmaintainable, unreadable, let's better put some things which are common for this test method and other test methods in this file into some common function and call it from both

agreed


> On March 28, 2014, 6:23 p.m., Andrew Onischuk wrote:
> > ambari-server/src/test/python/stacks/utils/RMFTestCase.py, line 138
> > <https://reviews.apache.org/r/19791/diff/1/?file=539870#file539870line138>
> >
> >     can you also please provide info and example how that works?

provided


> On March 28, 2014, 6:23 p.m., Andrew Onischuk wrote:
> > ambari-server/src/test/python/stacks/utils/RMFTestCase.py, line 148
> > <https://reviews.apache.org/r/19791/diff/1/?file=539870#file539870line148>
> >
> >     As far as I know, It's better style to have comma last, so next editions is easier

agreed


> On March 28, 2014, 6:23 p.m., Andrew Onischuk wrote:
> > ambari-server/src/test/python/stacks/utils/RMFTestCase.py, line 151
> > <https://reviews.apache.org/r/19791/diff/1/?file=539870#file539870line151>
> >
> >     Let's remove this, so all people use equal style of tests, that is better readable

explained


> On March 28, 2014, 6:23 p.m., Andrew Onischuk wrote:
> > ambari-server/src/test/python/stacks/utils/RMFTestCase.py, line 160
> > <https://reviews.apache.org/r/19791/diff/1/?file=539870#file539870line160>
> >
> >     can you also please attach example of new output?

provided


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19791/#review38926
-----------------------------------------------------------


On March 28, 2014, 6:12 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19791/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 6:12 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-5245
>     https://issues.apache.org/jira/browse/AMBARI-5245
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed jira, also refactored RMFTestCase.py a bit 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 8c63b23 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py b27bf61 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py 65d5e66 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py f257f83 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py a1c1b41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py d7f6e41 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 85fceca 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py 9e7630c 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 8a21873 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 82cedd8 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c835c94 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json  
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 8983882 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py b5adcbd 
> 
> Diff: https://reviews.apache.org/r/19791/diff/
> 
> 
> Testing
> -------
> 
> Tried installing 1.3.2 and 2.1 stacks, also tried 2-node cluster setup.
> 
> ----------------------------------------------------------------------
> Ran 190 tests in 0.460s
> 
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 19791: gmond.master.conf files are generated by Ganglia Server

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19791/#review38926
-----------------------------------------------------------



ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py
<https://reviews.apache.org/r/19791/#comment71258>

    don't copy the same content please in scripts, they get too big then and unmaintainable, unreadable, let's better put some things which are common for this test method and other test methods in this file into some common function and call it from both



ambari-server/src/test/python/stacks/utils/RMFTestCase.py
<https://reviews.apache.org/r/19791/#comment71256>

    can you also please provide info and example how that works?



ambari-server/src/test/python/stacks/utils/RMFTestCase.py
<https://reviews.apache.org/r/19791/#comment71255>

    As far as I know, It's better style to have comma last, so next editions is easier



ambari-server/src/test/python/stacks/utils/RMFTestCase.py
<https://reviews.apache.org/r/19791/#comment71251>

    Let's remove this, so all people use equal style of tests, that is better readable



ambari-server/src/test/python/stacks/utils/RMFTestCase.py
<https://reviews.apache.org/r/19791/#comment71254>

    can you also please attach example of new output?


- Andrew Onischuk


On March 28, 2014, 6:12 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19791/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 6:12 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-5245
>     https://issues.apache.org/jira/browse/AMBARI-5245
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed jira, also refactored RMFTestCase.py a bit 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 8c63b23 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py b27bf61 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py 65d5e66 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py f257f83 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py a1c1b41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py d7f6e41 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 85fceca 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py 9e7630c 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 8a21873 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 82cedd8 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c835c94 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json  
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 8983882 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py b5adcbd 
> 
> Diff: https://reviews.apache.org/r/19791/diff/
> 
> 
> Testing
> -------
> 
> Tried installing 1.3.2 and 2.1 stacks, also tried 2-node cluster setup.
> 
> ----------------------------------------------------------------------
> Ran 190 tests in 0.460s
> 
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 19791: gmond.master.conf files are generated by Ganglia Server

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19791/#review39163
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On April 1, 2014, 3:32 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19791/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 3:32 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-5245
>     https://issues.apache.org/jira/browse/AMBARI-5245
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed jira, also refactored RMFTestCase.py a bit 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 8c63b23 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py 030a627 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py 65d5e66 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py f257f83 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 2cf8e7b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py d7f6e41 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 85fceca 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py db48ceb 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 8a21873 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 02694bc 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c835c94 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json  
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 8983882 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py b5adcbd 
> 
> Diff: https://reviews.apache.org/r/19791/diff/
> 
> 
> Testing
> -------
> 
> Tried installing 1.3.2 and 2.1 stacks, also tried 2-node cluster setup.
> 
> ----------------------------------------------------------------------
> Ran 190 tests in 0.460s
> 
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 19791: gmond.master.conf files are generated by Ganglia Server

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19791/
-----------------------------------------------------------

(Updated April 1, 2014, 3:32 p.m.)


Review request for Ambari and Andrew Onischuk.


Changes
-------

Fixed listed issues with tests


Bugs: AMBARI-5245
    https://issues.apache.org/jira/browse/AMBARI-5245


Repository: ambari


Description
-------

Fixed jira, also refactored RMFTestCase.py a bit 


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 8c63b23 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py 030a627 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py 65d5e66 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py f257f83 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 2cf8e7b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py d7f6e41 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 85fceca 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py db48ceb 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 8a21873 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 02694bc 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c835c94 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json  
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 8983882 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py b5adcbd 

Diff: https://reviews.apache.org/r/19791/diff/


Testing
-------

Tried installing 1.3.2 and 2.1 stacks, also tried 2-node cluster setup.

----------------------------------------------------------------------
Ran 190 tests in 0.460s

OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko