You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/03/27 06:44:13 UTC
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4111: [Feature][Json-format] support read format for pulsar
hailin0 commented on code in PR #4111:
URL: https://github.com/apache/incubator-seatunnel/pull/4111#discussion_r1148812504
##########
seatunnel-connectors-v2/connector-pulsar/pom.xml:
##########
@@ -100,5 +100,23 @@
</exclusion>
</exclusions>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-format-text</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>pulsar</artifactId>
+ <version>${testcontainer.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
move to e2e module
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-pulsar-e2e/src/test/java/org/apache/seatunnel/e2e/connector/pulsar/CanalToPulsarIT.java:
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.e2e.connector.pulsar;
+
+import org.apache.seatunnel.connectors.seatunnel.cdc.mysql.testutils.MySqlContainer;
+import org.apache.seatunnel.connectors.seatunnel.cdc.mysql.testutils.MySqlVersion;
+import org.apache.seatunnel.connectors.seatunnel.cdc.mysql.testutils.UniqueDatabase;
+import org.apache.seatunnel.e2e.common.TestResource;
+import org.apache.seatunnel.e2e.common.TestSuiteBase;
+import org.apache.seatunnel.e2e.common.container.EngineType;
+import org.apache.seatunnel.e2e.common.container.TestContainer;
+import org.apache.seatunnel.e2e.common.junit.DisabledOnContainer;
+
+import org.apache.pulsar.client.admin.PulsarAdmin;
+import org.apache.pulsar.client.admin.PulsarAdminException;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.TestTemplate;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.Container;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.output.Slf4jLogConsumer;
+import org.testcontainers.lifecycle.Startables;
+import org.testcontainers.shaded.com.google.common.collect.Lists;
+import org.testcontainers.utility.DockerImageName;
+import org.testcontainers.utility.DockerLoggerFactory;
+import org.testcontainers.utility.MountableFile;
+
+import java.io.IOException;
+import java.util.stream.Stream;
+
+/**
+ * canal server producer data to pulsar, st-cdc is consumer reference:
+ * https://pulsar.apache.org/docs/2.11.x/io-canal-source/
+ */
+@DisabledOnContainer(
+ value = {},
+ type = {EngineType.FLINK, EngineType.SPARK})
+public class CanalToPulsarIT extends TestSuiteBase implements TestResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(CanalToPulsarIT.class);
+
+ // ----------------------------------------------------------------------------
+ // mysql
+ private static final String MYSQL_HOST = "mysql.e2e";
+
+ private static final int MYSQL_PORT = 3306;
+ public static final String MYSQL_USER = "st_user";
+ public static final String MYSQL_PASSWORD = "seatunnel";
+
+ private static final MySqlContainer MYSQL_CONTAINER = createMySqlContainer(MySqlVersion.V5_7);
+
+ private final UniqueDatabase inventoryDatabase =
+ new UniqueDatabase(MYSQL_CONTAINER, "canal", "mysqluser", "mysqlpw");
+
+ private static MySqlContainer createMySqlContainer(MySqlVersion version) {
+ MySqlContainer mySqlContainer =
+ new MySqlContainer(version)
+ .withConfigurationOverride("mysql/server-gtids/my.cnf")
+ .withSetupSQL("mysql/setup.sql")
+ .withNetwork(NETWORK)
+ .withNetworkAliases(MYSQL_HOST)
+ .withDatabaseName("canal")
+ .withUsername(MYSQL_USER)
+ .withPassword(MYSQL_PASSWORD)
+ .withLogConsumer(new Slf4jLogConsumer(LOG));
+ mySqlContainer.setPortBindings(
+ com.google.common.collect.Lists.newArrayList(
+ String.format("%s:%s", MYSQL_PORT, MYSQL_PORT)));
+ return mySqlContainer;
+ }
+
+ // ----------------------------------------------------------------------------
+ // canal
+ private static GenericContainer<?> CANAL_CONTAINER;
+
+ private static final String CANAL_DOCKER_IMAGE = "canal/canal-server:v1.1.2";
+
+ private static final String CANAL_HOST = "canal.e2e";
+
+ private void createCanalContainer() {
+ CANAL_CONTAINER =
+ new GenericContainer<>(CANAL_DOCKER_IMAGE)
+ .withNetwork(NETWORK)
+ .withNetworkAliases(CANAL_HOST)
+ .withLogConsumer(
+ new Slf4jLogConsumer(
+ DockerLoggerFactory.getLogger(CANAL_DOCKER_IMAGE)));
+ CANAL_CONTAINER.setPortBindings(
+ Lists.newArrayList("8000:8000", "2222:2222", "11111:11111", "11112:11112"));
+
+ CANAL_CONTAINER
+ .withEnv("canal.auto.scan", "false")
+ .withEnv("canal.destinations", "test")
+ .withEnv(
+ "canal.instance.master.address",
+ String.format("%s:%s", MYSQL_HOST, MYSQL_PORT))
+ .withEnv("canal.instance.dbUsername", MYSQL_USER)
+ .withEnv("canal.instance.dbPassword", MYSQL_PASSWORD)
+ .withEnv("canal.instance.connectionCharset", "UTF-8")
+ .withEnv("canal.instance.tsdb.enable", "true")
+ .withEnv("canal.instance.gtidon", "false");
+ }
+
+ // ----------------------------------------------------------------------------
+ // pulsar container
+ // download canal connector is so slowly,make it with canal connector from apache/pulsar
+ private static final String PULSAR_IMAGE_NAME = "laglangyue/pulsar_canal:2.3";
+
+ private static final int PULSAR_BROKER_PORT = 6650;
+ private static final int PULSAR_BROKER_REST_PORT = 8080;
+
+ private static final String PULSAR_HOST = "pulsar.e2e";
+
+ private static GenericContainer<?> PULSAR_CONTAINER;
+
+ private void createPulsarContainer() {
+ PULSAR_CONTAINER =
+ new GenericContainer<>(DockerImageName.parse(PULSAR_IMAGE_NAME))
+ .withNetwork(NETWORK)
+ .withNetworkAliases(PULSAR_HOST)
+ .withLogConsumer(
+ new Slf4jLogConsumer(
+ DockerLoggerFactory.getLogger(PULSAR_IMAGE_NAME)));
+
+ PULSAR_CONTAINER.setPortBindings(
+ com.google.common.collect.Lists.newArrayList(
+ String.format("%s:%s", PULSAR_BROKER_PORT, PULSAR_BROKER_PORT),
+ String.format("%s:%s", PULSAR_BROKER_REST_PORT, PULSAR_BROKER_REST_PORT)));
+
+ // canal connectors config
+ PULSAR_CONTAINER.withCopyFileToContainer(
+ MountableFile.forClasspathResource("pulsar/canal-mysql-source-config.yaml"),
+ "/pulsar/conf/");
+ // start connectors cmd
+ PULSAR_CONTAINER.withCopyFileToContainer(
+ MountableFile.forClasspathResource("pulsar/start_canal_connector.sh"), "/pulsar/");
+ }
+
+ private void startPulsarCanalConnector()
+ throws IOException, InterruptedException, PulsarAdminException {
+ Container.ExecResult chmod =
+ PULSAR_CONTAINER.execInContainer(
+ "chmod", "777", "/pulsar/start_canal_connector.sh");
+ Assertions.assertEquals(chmod.getExitCode(), 0);
+ // how to exec docker command backend ?
+ Container.ExecResult execResult =
+ PULSAR_CONTAINER.execInContainer(
+ "/bin/sh",
+ "-c",
+ "nohup /pulsar/start_canal_connector.sh > /pulsar/canal.log 2>&1 &");
+ // ensure connector start
+ PulsarAdmin pulsarAdmin =
+ PulsarAdmin.builder()
+ .serviceHttpUrl(
+ String.format(
+ "http://%s:%s",
+ PULSAR_CONTAINER.getHost(), PULSAR_BROKER_REST_PORT))
+ .build();
+ while (true) {
+ try {
+ if (!pulsarAdmin.topics().getList("public/default").isEmpty()) {
+ break;
+ }
+ } catch (Exception ignore) {
+ }
+
+ Thread.sleep(1000);
+ }
+ pulsarAdmin.close();
+ }
+
+ @BeforeAll
+ @Override
+ public void startUp() throws IOException, InterruptedException, PulsarAdminException {
+ LOG.info("The second stage: Starting Mysql containers...");
+ Startables.deepStart(Stream.of(MYSQL_CONTAINER)).join();
+ LOG.info("Mysql Containers are started");
+
+ LOG.info("The third stage: Starting Canal containers...");
+ createCanalContainer();
+ Startables.deepStart(Stream.of(CANAL_CONTAINER)).join();
+ LOG.info("Canal Containers are started");
+
+ LOG.info("The first stage: Starting Pulsar containers...");
+ createPulsarContainer();
+ Startables.deepStart(Stream.of(PULSAR_CONTAINER)).join();
+ LOG.info("Pulsar Containers are started");
+ LOG.info("start pulsar canal connector");
+ startPulsarCanalConnector();
+ LOG.info("pulsar canal connector start success");
+
+ inventoryDatabase.createAndInitialize();
+ }
+
+ @Override
+ public void tearDown() {
+ MYSQL_CONTAINER.close();
+ PULSAR_CONTAINER.close();
+ CANAL_CONTAINER.close();
+ }
+
+ @TestTemplate
+ void testContainer(TestContainer container) throws IOException, InterruptedException {
Review Comment:
```suggestion
void testCanalFormatMessages(TestContainer container) throws IOException, InterruptedException {
```
##########
docs/en/connector-v2/source/Pulsar.md:
##########
@@ -141,7 +150,7 @@ source {
Pulsar {
topic = "example"
subscription.name = "seatunnel"
- client.service-url = "localhost:pulsar://localhost:6650"
+ client.service-url = "pulsar://localhost:6650"
Review Comment:
uodate `Changelog`
##########
seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/source/reader/PulsarSourceReader.java:
##########
@@ -203,6 +199,10 @@ protected PulsarSplitReaderThread createPulsarSplitReaderThread(PulsarPartitionS
public void handleNoMoreElements(String splitId, MessageId messageId) {
LOG.info("Reader received the split {} NoMoreElements event.", splitId);
pendingCursorsToFinish.put(splitId, messageId);
+ // BOUNDED not trigger snapshot and notifyCheckpointComplete
+ if (context.getBoundedness() == Boundedness.BOUNDED) {
+ finishedSplits.add(splitId);
+ }
Review Comment:
good
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-pulsar-e2e/src/test/java/org/apache/seatunnel/e2e/connector/pulsar/CanalToPulsarIT.java:
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.e2e.connector.pulsar;
+
+import org.apache.seatunnel.connectors.seatunnel.cdc.mysql.testutils.MySqlContainer;
+import org.apache.seatunnel.connectors.seatunnel.cdc.mysql.testutils.MySqlVersion;
+import org.apache.seatunnel.connectors.seatunnel.cdc.mysql.testutils.UniqueDatabase;
+import org.apache.seatunnel.e2e.common.TestResource;
+import org.apache.seatunnel.e2e.common.TestSuiteBase;
+import org.apache.seatunnel.e2e.common.container.EngineType;
+import org.apache.seatunnel.e2e.common.container.TestContainer;
+import org.apache.seatunnel.e2e.common.junit.DisabledOnContainer;
+
+import org.apache.pulsar.client.admin.PulsarAdmin;
+import org.apache.pulsar.client.admin.PulsarAdminException;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.TestTemplate;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.Container;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.output.Slf4jLogConsumer;
+import org.testcontainers.lifecycle.Startables;
+import org.testcontainers.shaded.com.google.common.collect.Lists;
+import org.testcontainers.utility.DockerImageName;
+import org.testcontainers.utility.DockerLoggerFactory;
+import org.testcontainers.utility.MountableFile;
+
+import java.io.IOException;
+import java.util.stream.Stream;
+
+/**
+ * canal server producer data to pulsar, st-cdc is consumer reference:
+ * https://pulsar.apache.org/docs/2.11.x/io-canal-source/
+ */
+@DisabledOnContainer(
+ value = {},
+ type = {EngineType.FLINK, EngineType.SPARK})
+public class CanalToPulsarIT extends TestSuiteBase implements TestResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(CanalToPulsarIT.class);
+
+ // ----------------------------------------------------------------------------
+ // mysql
+ private static final String MYSQL_HOST = "mysql.e2e";
+
+ private static final int MYSQL_PORT = 3306;
+ public static final String MYSQL_USER = "st_user";
+ public static final String MYSQL_PASSWORD = "seatunnel";
+
+ private static final MySqlContainer MYSQL_CONTAINER = createMySqlContainer(MySqlVersion.V5_7);
+
+ private final UniqueDatabase inventoryDatabase =
+ new UniqueDatabase(MYSQL_CONTAINER, "canal", "mysqluser", "mysqlpw");
+
+ private static MySqlContainer createMySqlContainer(MySqlVersion version) {
+ MySqlContainer mySqlContainer =
+ new MySqlContainer(version)
+ .withConfigurationOverride("mysql/server-gtids/my.cnf")
+ .withSetupSQL("mysql/setup.sql")
+ .withNetwork(NETWORK)
+ .withNetworkAliases(MYSQL_HOST)
+ .withDatabaseName("canal")
+ .withUsername(MYSQL_USER)
+ .withPassword(MYSQL_PASSWORD)
+ .withLogConsumer(new Slf4jLogConsumer(LOG));
+ mySqlContainer.setPortBindings(
+ com.google.common.collect.Lists.newArrayList(
+ String.format("%s:%s", MYSQL_PORT, MYSQL_PORT)));
+ return mySqlContainer;
+ }
+
+ // ----------------------------------------------------------------------------
+ // canal
+ private static GenericContainer<?> CANAL_CONTAINER;
+
+ private static final String CANAL_DOCKER_IMAGE = "canal/canal-server:v1.1.2";
+
+ private static final String CANAL_HOST = "canal.e2e";
+
+ private void createCanalContainer() {
+ CANAL_CONTAINER =
+ new GenericContainer<>(CANAL_DOCKER_IMAGE)
+ .withNetwork(NETWORK)
+ .withNetworkAliases(CANAL_HOST)
+ .withLogConsumer(
+ new Slf4jLogConsumer(
+ DockerLoggerFactory.getLogger(CANAL_DOCKER_IMAGE)));
+ CANAL_CONTAINER.setPortBindings(
+ Lists.newArrayList("8000:8000", "2222:2222", "11111:11111", "11112:11112"));
+
+ CANAL_CONTAINER
+ .withEnv("canal.auto.scan", "false")
+ .withEnv("canal.destinations", "test")
+ .withEnv(
+ "canal.instance.master.address",
+ String.format("%s:%s", MYSQL_HOST, MYSQL_PORT))
+ .withEnv("canal.instance.dbUsername", MYSQL_USER)
+ .withEnv("canal.instance.dbPassword", MYSQL_PASSWORD)
+ .withEnv("canal.instance.connectionCharset", "UTF-8")
+ .withEnv("canal.instance.tsdb.enable", "true")
+ .withEnv("canal.instance.gtidon", "false");
+ }
+
+ // ----------------------------------------------------------------------------
+ // pulsar container
+ // download canal connector is so slowly,make it with canal connector from apache/pulsar
+ private static final String PULSAR_IMAGE_NAME = "laglangyue/pulsar_canal:2.3";
+
+ private static final int PULSAR_BROKER_PORT = 6650;
+ private static final int PULSAR_BROKER_REST_PORT = 8080;
+
+ private static final String PULSAR_HOST = "pulsar.e2e";
+
+ private static GenericContainer<?> PULSAR_CONTAINER;
+
+ private void createPulsarContainer() {
+ PULSAR_CONTAINER =
+ new GenericContainer<>(DockerImageName.parse(PULSAR_IMAGE_NAME))
+ .withNetwork(NETWORK)
+ .withNetworkAliases(PULSAR_HOST)
+ .withLogConsumer(
+ new Slf4jLogConsumer(
+ DockerLoggerFactory.getLogger(PULSAR_IMAGE_NAME)));
+
+ PULSAR_CONTAINER.setPortBindings(
+ com.google.common.collect.Lists.newArrayList(
+ String.format("%s:%s", PULSAR_BROKER_PORT, PULSAR_BROKER_PORT),
+ String.format("%s:%s", PULSAR_BROKER_REST_PORT, PULSAR_BROKER_REST_PORT)));
+
+ // canal connectors config
+ PULSAR_CONTAINER.withCopyFileToContainer(
+ MountableFile.forClasspathResource("pulsar/canal-mysql-source-config.yaml"),
+ "/pulsar/conf/");
+ // start connectors cmd
+ PULSAR_CONTAINER.withCopyFileToContainer(
+ MountableFile.forClasspathResource("pulsar/start_canal_connector.sh"), "/pulsar/");
+ }
+
+ private void startPulsarCanalConnector()
+ throws IOException, InterruptedException, PulsarAdminException {
+ Container.ExecResult chmod =
+ PULSAR_CONTAINER.execInContainer(
+ "chmod", "777", "/pulsar/start_canal_connector.sh");
+ Assertions.assertEquals(chmod.getExitCode(), 0);
+ // how to exec docker command backend ?
+ Container.ExecResult execResult =
+ PULSAR_CONTAINER.execInContainer(
+ "/bin/sh",
+ "-c",
+ "nohup /pulsar/start_canal_connector.sh > /pulsar/canal.log 2>&1 &");
+ // ensure connector start
+ PulsarAdmin pulsarAdmin =
+ PulsarAdmin.builder()
+ .serviceHttpUrl(
+ String.format(
+ "http://%s:%s",
+ PULSAR_CONTAINER.getHost(), PULSAR_BROKER_REST_PORT))
+ .build();
+ while (true) {
+ try {
+ if (!pulsarAdmin.topics().getList("public/default").isEmpty()) {
+ break;
+ }
+ } catch (Exception ignore) {
+ }
+
+ Thread.sleep(1000);
+ }
+ pulsarAdmin.close();
+ }
+
+ @BeforeAll
+ @Override
+ public void startUp() throws IOException, InterruptedException, PulsarAdminException {
+ LOG.info("The second stage: Starting Mysql containers...");
+ Startables.deepStart(Stream.of(MYSQL_CONTAINER)).join();
+ LOG.info("Mysql Containers are started");
+
+ LOG.info("The third stage: Starting Canal containers...");
+ createCanalContainer();
+ Startables.deepStart(Stream.of(CANAL_CONTAINER)).join();
+ LOG.info("Canal Containers are started");
+
+ LOG.info("The first stage: Starting Pulsar containers...");
+ createPulsarContainer();
+ Startables.deepStart(Stream.of(PULSAR_CONTAINER)).join();
+ LOG.info("Pulsar Containers are started");
+ LOG.info("start pulsar canal connector");
+ startPulsarCanalConnector();
+ LOG.info("pulsar canal connector start success");
+
+ inventoryDatabase.createAndInitialize();
+ }
+
+ @Override
+ public void tearDown() {
+ MYSQL_CONTAINER.close();
+ PULSAR_CONTAINER.close();
+ CANAL_CONTAINER.close();
+ }
+
+ @TestTemplate
+ void testContainer(TestContainer container) throws IOException, InterruptedException {
+ Container.ExecResult execResult = container.executeJob("/cdc_canal_pulsar_to_console.conf");
+ Assertions.assertEquals(0, execResult.getExitCode(), execResult.getStderr());
Review Comment:
reference check cdc sink output
https://github.com/apache/incubator-seatunnel/pull/3950#discussion_r1090141130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org