You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/10 10:42:56 UTC
[GitHub] [airflow] victorphoenix3 opened a new pull request #21488: Refactor query polling logic for athena queries
victorphoenix3 opened a new pull request #21488:
URL: https://github.com/apache/airflow/pull/21488
Query status polling logic currently polls until the query is not in intermmediate state. It should instead poll until query is not in the terminal state.
Similar to https://github.com/apache/airflow/issues/19877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1040540596
Some tests are failing :( (related)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21488:
URL: https://github.com/apache/airflow/pull/21488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] victorphoenix3 commented on a change in pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
victorphoenix3 commented on a change in pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#discussion_r820709662
##########
File path: tests/providers/amazon/aws/operators/test_athena.py
##########
@@ -72,7 +72,7 @@ def test_init(self):
assert self.athena.hook.sleep_time == 0
- @mock.patch.object(AthenaHook, 'check_query_status', side_effect=("SUCCESS",))
Review comment:
'SUCCESS' is not a state for athena queries, "SUCCEEDED" is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1040540596
Some tests are failing :( (related)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1060623622
@victorphoenix3 can you please fix the failing tests?
https://github.com/apache/airflow/runs/5156246799?check_suite_focus=true#step:7:4789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1040540596
Some tests are failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] victorphoenix3 commented on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
victorphoenix3 commented on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1060695420
@eladkal I have updated the PR. Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] victorphoenix3 commented on a change in pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
victorphoenix3 commented on a change in pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#discussion_r820709662
##########
File path: tests/providers/amazon/aws/operators/test_athena.py
##########
@@ -72,7 +72,7 @@ def test_init(self):
assert self.athena.hook.sleep_time == 0
- @mock.patch.object(AthenaHook, 'check_query_status', side_effect=("SUCCESS",))
Review comment:
'SUCCESS' is not a state for athena queries, "SUCCEEDED" is. The tests were failing because of this discrepancy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1061134495
@victorphoenix3 can you please rebase? tests are broken due to issue with moto (was already fixed in https://github.com/apache/airflow/pull/22046 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] victorphoenix3 commented on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
victorphoenix3 commented on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1061812760
@eladkal PR is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21488: Refactor query polling logic for athena queries
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21488:
URL: https://github.com/apache/airflow/pull/21488#issuecomment-1040540596
Some tests are failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org