You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/25 12:20:06 UTC
[GitHub] [camel] essobedo opened a new pull request, #8778: CAMEL-18731: Add result type and different sources of input data to languages
essobedo opened a new pull request, #8778:
URL: https://github.com/apache/camel/pull/8778
Fixes https://issues.apache.org/jira/browse/CAMEL-18731
## Motivation:
We need to have `resultTypeName`, `resultType`, `headerName`, and/or `propertyName` for all languages for which it can make sense.
## Modifications:
* Add `resultTypeName` and `resultType` to bean, groovy, hl7terser, mvel, ognl, ref, spel, ref and XQuery
* Add `headerName` and/or `propertyName` to xquery, hl7terser, jq, jsonpath, tokenize, xpath, XQuery, xtokenize
* Remove `headerName` from js and python since they already provide the headers as part of the input data
* Add several classes for type "Typed..." as the base class for all the languages that support the result type
* Add several classes for type "SingleInputTyped..." as the base class for all the languages that support the result type and different sources of input data
* Add several classes for type "SingleInput..." as the base class for all the languages that support different sources of input data but not the result type
* Add several abstract test classes to extend to validate the behavior of each language affected by these changes
* Add missing attributes to the annotations `@Joor`, `@JsonPath`, `@XQuery`, `@XPath`
* Set the result type when applicable in the methods `xpath` and `xquery` of `ExpressionClauseSupport`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327671825
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 18 | 18 | 0 | 19 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327407024
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327602608
I don't add any dependency to `camel-bean`, from `camel-bean`, the only new class that refers to is `TypedLanguageSupport` which is part of `camel-support` not `camel-core`.
Regarding the test for the `bean` language, it is not in `camel-bean` but in `camel-core`.
In both cases, I'm sorry but it is still not clear to me what's wrong. Could you please share with me the line(s) in the code where the problem is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo merged pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
essobedo merged PR #8778:
URL: https://github.com/apache/camel/pull/8778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327570360
camel-bean was in v2 in core, and tests for bean are 99% in camel-core and should stay there.
Also you can end up with maven not able to build the project from 100% clean due to camel-bean is needed in core, and core is not build yet - only because your local m2 repo have camel-core test-jar already it can use that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327609473
Ah my bad - its a big PR, but I saw
```
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-core</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>
```
And had in my head that you added this to camel-bean, but it was to another language that was not in core in v2 - so this seems okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327481345
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 17 | 17 | 1 | 17 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327525239
> @essobedo you cannot have camel-core dependency in camel-bean when testing due to build order problems. So ideally have tests in core/camel-core, and only some basic tests in camel-bean
@davsclaus Hi Claus, thx for the remark, however, I don't get it, I have added camel-core in camel-bean and the test for the bean language is already in core, so I'm confused. Could you please clarify a bit more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1327480132
@essobedo you cannot have camel-core dependency in camel-bean when testing due to build order problems. So ideally have tests in core/camel-core, and only some basic tests in camel-bean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8778: CAMEL-18731: Add result type and different sources of input data to languages
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8778:
URL: https://github.com/apache/camel/pull/8778#issuecomment-1328013051
Thanks for this great work to cleanup and align the languages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org