[GitHub] [accumulo] ctubbsii commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables
URL: https://github.com/apache/accumulo/pull/1518#discussion_r384593482
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/NamespaceOperationsImpl.java
 ##########
 @@ -163,7 +166,11 @@ public void delete(String namespace) throws AccumuloException, AccumuloSecurityE
   public void rename(String oldNamespaceName, String newNamespaceName)
       throws AccumuloSecurityException, NamespaceNotFoundException, AccumuloException,
       NamespaceExistsException {
-
+    checkArgument(oldNamespaceName.length() <= MAX_NAMESPACE_LEN,
 
 Review comment:
   @cradal No. Sorry for the confusion. The intention was:
   
   1. prevent the creation of new objects over the limit, and
   2. log a warning when we discover any object over the limit (with the understanding that this would only be possible for objects created before the limit was imposed)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services